mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Josh Law <objecting@objecting.org>,
	linux-trace-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v8 05/13] lib/bootconfig: drop redundant memset of xbc_nodes
Date: Wed, 18 Mar 2026 21:22:31 +0100	[thread overview]
Message-ID: <026f4ec4-8436-4fa5-bd69-f194cdf7a93f@web.de> (raw)
In-Reply-To: <20260318155919.78168-6-objecting@objecting.org>

> memblock_alloc() already returns zeroed memory,

Interesting …


>                                                 so the explicit memset
> in xbc_init() is redundant. …

Would you like to reconsider this conclusion for the mentioned function implementation
in more detail?
https://elixir.bootlin.com/linux/v7.0-rc4/source/lib/bootconfig.c#L932-L998

Regards,
Markus

  reply	other threads:[~2026-03-18 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 15:59 [PATCH v8 00/13] bootconfig: cleanups, correctness, and modernization Josh Law
2026-03-18 15:59 ` [PATCH v8 01/13] lib/bootconfig: clean up comment typos and bracing Josh Law
2026-03-18 15:59 ` [PATCH v8 02/13] lib/bootconfig: narrow flag parameter type from uint32_t to uint16_t Josh Law
2026-03-18 15:59 ` [PATCH v8 03/13] lib/bootconfig: fix off-by-one in xbc_verify_tree() next node check Josh Law
2026-03-18 15:59 ` [PATCH v8 04/13] lib/bootconfig: increment xbc_node_num after node init succeeds Josh Law
2026-03-18 15:59 ` [PATCH v8 05/13] lib/bootconfig: drop redundant memset of xbc_nodes Josh Law
2026-03-18 20:22   ` Markus Elfring [this message]
2026-03-18 15:59 ` [PATCH v8 06/13] bootconfig: constify xbc_calc_checksum() data parameter Josh Law
2026-03-18 15:59 ` [PATCH v8 07/13] lib/bootconfig: replace linux/kernel.h with specific includes Josh Law
2026-03-18 15:59 ` [PATCH v8 08/13] lib/bootconfig: validate child node index in xbc_verify_tree() Josh Law
2026-03-18 15:59 ` [PATCH v8 09/13] lib/bootconfig: fix signed comparison in xbc_node_get_data() Josh Law
2026-03-18 15:59 ` [PATCH v8 10/13] lib/bootconfig: use size_t for strlen result in xbc_node_match_prefix() Josh Law
2026-03-18 15:59 ` [PATCH v8 11/13] lib/bootconfig: use signed type for offset in xbc_init_node() Josh Law
2026-03-18 15:59 ` [PATCH v8 12/13] lib/bootconfig: use size_t for key length tracking in xbc_verify_tree() Josh Law
2026-03-18 15:59 ` [PATCH v8 13/13] lib/bootconfig: change xbc_node_index() return type to uint16_t Josh Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=026f4ec4-8436-4fa5-bd69-f194cdf7a93f@web.de \
    --to=markus.elfring@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=objecting@objecting.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®