From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Kris Borer <kborer@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: cocci script from 2016 - assignment in if ?
Date: Thu, 25 Jun 2020 00:49:10 -0700 [thread overview]
Message-ID: <027076b1335f3b48307c78a3d6d1573fa8975822.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006250848260.3692@hadrien>
On Thu, 2020-06-25 at 08:49 +0200, Julia Lawall wrote:
>
> On Wed, 24 Jun 2020, joe@perches.com wrote:
>
> > https://lore.kernel.org/patchwork/patch/649705/
> >
> > Any particular reason this wasn't applied?
> >
> > I ask because I added something similar recently to checkpatch.
>
> It probably slipped through the cracks at the time the Coccinelle
> scripts maintainer disappeared. I can check and see if it does anything
> more than your script.
The checkpatch thing only works on single lines,
so this cocci script looks more whitespace robust
but this script doesn't appear to handle code like
if (!(foo = bar(...)))
baz;
where the checkpatch thing converts it OK.
prev parent reply other threads:[~2020-06-25 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 2:35 joe
2020-06-25 6:49 ` Julia Lawall
2020-06-25 7:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=027076b1335f3b48307c78a3d6d1573fa8975822.camel@perches.com \
--to=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®