From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2015A6D1C7 for ; Mon, 8 Apr 2024 12:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712580364; cv=none; b=jpD+IoNzgPSqu+9bnKXOB+VGmfIhhJcKgvI8DIjpMSrkbnwf1zvfiXH49nXxxIMJAoMMmRtxEf1sLJfDQo1XujDkpGleCN+b9Wp1EIkJc1KJJ/kBr30HeE3vZaPeXdFnPU03xFdp9RTybIWTBCmamkyYW4yoPbR1NKmArGPmWg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712580364; c=relaxed/simple; bh=4f3UaY0SQf8Ijcwk4KQ6V3GH86m2/eSeNdDdmV3Y56c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m5t9tmbK8qZV9uquHN7LBdZ8oadsEjs2wuUYUpvdNyN3XRLZ/i5NzmRwwYCFRGnb0VHflLD95IDuvDqcaLCL/XqVPHjCSYNSuG/4Zwie4FDsO8xmUXzNQg9Ieep2iyASXVgGqpl1rfG4CNp7U5XNDspV0U5iZUVrEk1IsuzZTPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FIllcz5A; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FIllcz5A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712580362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oa0dQJ1NfzkDJ58Nm3G99Pr4wnpg2bxLGHQnIfyvxPo=; b=FIllcz5AT/e+iGrg55MU+t96qWikN8RecNp/r2BRWmbVp2Glw9+W0mqn9uhzBDzhT1FakA rlLguk7FQjtTZomKhdC5Kl5kFDta+hcT0l2oZem6l0KRuuqwm3oGvuujy1niKl6gebbHDt AOzkDwHfUa63ExJe/UlUUif7ipMxDEc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-syBdrn9pMmmiPTCQx-SFTQ-1; Mon, 08 Apr 2024 08:46:00 -0400 X-MC-Unique: syBdrn9pMmmiPTCQx-SFTQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a466c7b0587so273523466b.0 for ; Mon, 08 Apr 2024 05:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712580359; x=1713185159; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oa0dQJ1NfzkDJ58Nm3G99Pr4wnpg2bxLGHQnIfyvxPo=; b=vT6007CSaftV9ofVcfe76d0oOAZlTeueW3tNqDwW9wobeeOAtVcwaUGt4zlcFKb+0a Q8habhJrp8Sc3BsWfrN92537qD9N7h1DR4b8xo/cdDYA682fEu2KZ1FCOnf4wU2NXlqH eyWzbRtk0HIeTn8c8C6KS9W5qUrDaCLTtv5UHYGxIVU/rqErD560QMk0WO8RV/7QZSdL jNLHyYQKEWIg9ps2IpVn4L0QBB5qbYc0YFZLTwcPNnSCoDB1PGOHEHniNXDoSv48YRU8 8TC82WgIZmvKiKX7lFY5oWMjJATVbvoPI5cYftIGWoUWrdl0P16eXmRmQqq4ygT95Ac6 Ht2Q== X-Forwarded-Encrypted: i=1; AJvYcCWRIzu3OXTCcnnCcJO+dh0cTcoZB6POcd7qtVpdP0iaC6b5mQMobGZ7N6TeSMcS2dyRzPBEHQooLTShtUm9t63hphUsIeQZcaMIjI1u X-Gm-Message-State: AOJu0Yx1lYfga5dY3WzyOh1+hoV257hcXhf+rmcpEw+ROkMmvM2l3JYS /hCJziq7Mfw9yO2VsgU9bj4IGH+vY6+pLHfR537Gjn9sXCR/C0dWrSEbu4VM7iN0cjyh2NDBiF3 v1HEwBOeVBbVcJEwdCwJrNxOJ+bKI1RC2urwsjVbiNDwr0JAgl3lXIzm+dZlQqg== X-Received: by 2002:a17:907:3da8:b0:a51:dc1f:a44b with SMTP id he40-20020a1709073da800b00a51dc1fa44bmr1478664ejc.29.1712580359461; Mon, 08 Apr 2024 05:45:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEkiynBLyuS7R8ea5n9gdwWhf7wBEZd2/uGpnUdhbhQ06ApoM00sS+9w3QyJnVOqX1gm8maA== X-Received: by 2002:a17:907:3da8:b0:a51:dc1f:a44b with SMTP id he40-20020a1709073da800b00a51dc1fa44bmr1478641ejc.29.1712580359092; Mon, 08 Apr 2024 05:45:59 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id ag13-20020a1709069a8d00b00a51ab065bf0sm3955072ejc.202.2024.04.08.05.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 05:45:58 -0700 (PDT) Message-ID: <027b14ff-a6fe-456c-b3b5-187fd435ac3f@redhat.com> Date: Mon, 8 Apr 2024 14:45:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes To: Mark Pearson Cc: ilpo.jarvinen@linux.intel.com, hmh@hmh.eng.br, dmitry.torokhov@gmail.com, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, njoshi1@lenovo.com, vsankar@lenovo.com, peter.hutterer@redhat.com References: <20240324210817.192033-1-mpearson-lenovo@squebb.ca> <20240324210817.192033-2-mpearson-lenovo@squebb.ca> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240324210817.192033-2-mpearson-lenovo@squebb.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 3/24/24 10:07 PM, Mark Pearson wrote: > Add support for new input events on Lenovo laptops that need exporting to > user space. > > Lenovo trackpoints are adding the ability to generate a doubletap event. > Add a new keycode to allow this to be used by userspace. > > Lenovo support is using FN+N with Windows to collect needed details for > support cases. Add a keycode so that we'll be able to provide similar > support on Linux. > > Suggested-by: Peter Hutterer > > Signed-off-by: Mark Pearson > Signed-off-by: Nitin Joshi > Signed-off-by: Vishnu Sankar Thanks, patch looks good to me: Reviewed-by: Hans de Goede Dmitry, can I have your ack for merging this change through the pdx86 tree (since the first driver using these is a pdx86 driver) ? Regards, Hans > --- > include/uapi/linux/input-event-codes.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 03edf2ccdf6c..bd3baca95749 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -686,6 +686,8 @@ > #define KEY_SIDEVU_SONAR 0x287 > #define KEY_NAV_INFO 0x288 > #define KEY_BRIGHTNESS_MENU 0x289 > +#define KEY_DOUBLECLICK 0x28a > +#define KEY_SYS_DEBUG_INFO 0x28b > > /* > * Some keyboards have keys which do not have a defined meaning, these keys