From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75BE01DD525 for ; Tue, 30 Dec 2025 13:28:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767101332; cv=none; b=IpV/3XN8n/UoYiHAsvNJxkHzQqhpQrCqpuOCklXVro2UvMyBd4TThWyJJlnnskkisaUpvWw3Uiw4LM7A+ipjPFHdh7K6OFl9zmoKvsXTe2Ka1XPikVcKvVti1r5qHtwDp5oxqYVy7edD5iJpsPJPkMxcaULOUgCl/i/ryznVt5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767101332; c=relaxed/simple; bh=gCE9g7o9NshJ8d3/8lbuNSi3lr3Q2YYPLKNEMOGnsSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=elvUDNrmgM5ZZGw+n0rwDQzmFbsDVdttYbPdCXnrinxdZ/fQtOIGFqEYZlxtLgR5qg3wluqkkpTFocUPIh2tDy7M38TxUAYBzF/7QtFiWksj+Ncm8yPK9uZEeGtYTOx1VADLY3IOQjUNVpK0pM9n05Qv8UPpExmzYX16pJLFoX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X5kob5xb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OvUU+Zw4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X5kob5xb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OvUU+Zw4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BU9V5N82551303 for ; Tue, 30 Dec 2025 13:28:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SbPCrSTHdAIMNZfqnVN4Vn/bScRCYxDUiISVKD+AQEI=; b=X5kob5xb94UNZrZp SCqw6yb08ARzaMl3g4Yznm/uhr+bDna117Rh6Sg5kqHc8m+/+LXEo2/PIBAXQKj2 NZkKO7EnRIDFGPDvfJiqojA8hEvWdLA5d3SpfX2Y2ufJKQVYcbgBfQDCGupZRVXg jwUW7xqmlRzWMX+8FZazdNxw2XICaZLH5K8TIuOt48FokmN3AIcgWHdhlXGF1pED 2F3P6loAlKEdRUlvLOpy5Q/strGjTGMpuZGT8SxJZa9cuzd7DOftpLbN9F1Q9Exf FpAtg2qsub+b3gah2zquzpsvJh7/ZWT9KTSUqPdyehNyB/jugMGBeN2Safdoxhpb ebe8yw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bc0skhxs1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Dec 2025 13:28:50 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f34c24e2cbso33073561cf.3 for ; Tue, 30 Dec 2025 05:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767101330; x=1767706130; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SbPCrSTHdAIMNZfqnVN4Vn/bScRCYxDUiISVKD+AQEI=; b=OvUU+Zw4ikJwU9S9lNRAnQQ8U2HiBGOyGhwZ3Zul0bKz0tVJof6oYw2ZXV3dNQKsZB V/aq478TR9mffTq0E8Gk++DTNV+6zgJsynIzVzz8CjJjQA6WbNqPiQPbUg/8t9TxhVhA B+nW6RDy3e/O4aX/QcAdFu49FQUaJDXPP5Bz4a4kVi/BtI4apqpnf3PT6K2JV1+FzBZv Zm+CoK1ka9Y6FlXIFuipRpNWorFmv0jmmfgRWCM++wHp1hG5HiGbsACQ5EoZvxGCoGy1 m7N0mgFixX398RW8rxweX3U+dsQFTtXjKNCafYSsflnSKiOyHxbODBHcWxS/7Pe/6gMl 5cLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767101330; x=1767706130; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SbPCrSTHdAIMNZfqnVN4Vn/bScRCYxDUiISVKD+AQEI=; b=DZJOY4F2Z6Qtp35MusKWW0/fdFYzp/aLoRri8lKaKqGPW9vJ3A2uKOPFuHXH8gFOqr XgJvWfdmZ3SbMbU1BFrZ2TG7af9CGLFnFIBTJNf30ixdM5m2B8RSXE+mRzM7NjNdrCJf so1+Vtks7sGpRcYlB/Mn6WkHpMnCeSCUqKtDfQEvD/GUagTLdbZ1PQAg7b8DAJ5WONZu bjWP/9zn1m1Pf8qszu3IeRptQV7G5Fe9aaY5xVNqSJEPpJYWKLcuiLTbAt0okl4JT72d ggYFs/6Tdmkwe/AGSkGO2M0DGm18hFmldIwc6bsu/APEbKs9Ujaq0HdDLP6aJkeYS9Zm FSZw== X-Forwarded-Encrypted: i=1; AJvYcCWpq+nrYohixOQ4YY6azKP5gXpawPPP+ay8aG6P3DVF3fBz0VbYRBhieqM+rKa3uw0b0mmoIaJR8K2z0w8=@vger.kernel.org X-Gm-Message-State: AOJu0YyXoo89xdeLNJ4oH+SHJWiRgT/qn++ee0lCwyDhiVqzoY2CBgtG 0VHpv034GIRjsq7DoLBpL/PVjjc5Zhr/cXBDuTGFEzDKMNZS6th/EvgovLOyUh8bAuvmNYXJO6p tIpTLD1ojaIqQSDVrMqhRy4EjA+4KJyFPd4y0sSf0xNbuaLB19JN49SNxIp+z2h8VCSE= X-Gm-Gg: AY/fxX5TWS0/nrmY69Z9KJCNxoWTgF04NJ1azEC+3o0qMTLoM2b6qU6j5XiCMTDmoel 4CnOHoeQhzCmxp/R4yu2pDmGizP2RzVPCrWCFxnQp+ARpNbRis8twtLmKWXtn5t8APxkXizyqpx ABD51Swe/5sppAAA4mibgH61FsxtEFfu8EAOWFi2wp5426nZwnrMLgGiTXOe/Yle4Rrca7hHTvX huCJuV6RAiZ23EA/IXa62B+5a7+LBCy112uTT2fLxQCbO8D7ncw+uN1Gx2TzMwuhE6oumWkK5XU CBam9VBIGd2GuosYhS0hunrmwotMzzjl5H69Q+dRTWAVexwLl9g3EDDrQveGnSizJLIOKcNjoR2 mKNyCd7OVpPfZHtjThRh8AfJMvtXrwHqX1m7SB2xeGsIHovjaDOR/2D/SzdjG4oM5aQ== X-Received: by 2002:a05:622a:241:b0:4f3:6170:26f4 with SMTP id d75a77b69052e-4f4abbc06ddmr358865261cf.0.1767101329760; Tue, 30 Dec 2025 05:28:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDF3yEn4U8C4OQp+pO5mkvPfTN8DijTooC3QyATKwQ9+kddc49uVi89CloOxfApcHCZh7uHQ== X-Received: by 2002:a05:622a:241:b0:4f3:6170:26f4 with SMTP id d75a77b69052e-4f4abbc06ddmr358864901cf.0.1767101329256; Tue, 30 Dec 2025 05:28:49 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f512e3sm3630116366b.67.2025.12.30.05.28.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 05:28:48 -0800 (PST) Message-ID: <027c3ba9-70bc-4c03-ac7c-07c7a8a865e7@oss.qualcomm.com> Date: Tue, 30 Dec 2025 14:28:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK To: Ekansh Gupta , srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com References: <20251230062831.1195116-1-ekansh.gupta@oss.qualcomm.com> <20251230062831.1195116-3-ekansh.gupta@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251230062831.1195116-3-ekansh.gupta@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjMwMDEyMSBTYWx0ZWRfX+lElNOI8/li3 mPAVoZZqkCH32CuR/txO2Qzs6XJQInqlPGORGN4AR3CcfT1jqd+scvTMksYkgCxJmeXxLwdqqV8 nPkgWZ2XizypRto7LH9EwPTL2U4phvCsAarMhlQOcmGRe6g9slu86f4nODLQ/7HCV7c+LAGWEhZ zlPRpV06u7K0fu4sgtTgxLVH2BhnEaoFPrW/TPVZLLuhNLXuZ1m6opuSo8EKHrPLLHrYGmKpfDS m8iEOBssyd20PCPf+h9EHohYOkAOSgTmkU9WAlPVBaAav+J12EOBgXUBJkBoDUSwJBAtWOoj/VY 9LioaRgHuQFbOINcr35OkDEEaMr/oG51CfCX0syc1gbNrcjhooW8zHcq/Em28jISp49u3C+TEUi FfB+jdD6DVv6Kenm8T7zRfU8wuGvMFqM4IeDhp169hTS3MiOhuBro5ivqB2dpx8Ve65HUrK3qkr T2pSOb3RJNW+FUaOrHQ== X-Proofpoint-ORIG-GUID: JwCowVXI6FTAE-syEZzNVdiOkqBj8OOS X-Proofpoint-GUID: JwCowVXI6FTAE-syEZzNVdiOkqBj8OOS X-Authority-Analysis: v=2.4 cv=FJ0WBuos c=1 sm=1 tr=0 ts=6953d392 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=WZKhdRBjRjmf9s70GbYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-30_01,2025-12-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512300121 On 12/30/25 7:28 AM, Ekansh Gupta wrote: > Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to > improve readability and follow kernel bitfield conventions. Use > FIELD_PREP and FIELD_GET instead of manual shifts for setting and > extracting ctxid values. > > Signed-off-by: Ekansh Gupta > --- > drivers/misc/fastrpc.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 679cd8997a00..f7fb44a8e9c0 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include nit: these are best when sorted Reviewed-by: Konrad Dybcio Konrad