From: Adrian Hunter <adrian.hunter@intel.com>
To: Frank.Li@oss.nxp.com,
"Aubin Constans" <aubin.constans@microchip.com>,
"Ulf Hansson" <ulfh@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Jesper Nilsson" <jesper.nilsson@axis.com>,
"Lars Persson" <lars.persson@axis.com>,
"John Garry" <john.garry@linux.dev>,
"Hemanth Selam" <hemanth.selam@gmail.com>,
"Pengpeng Hou" <pengpeng@iscas.ac.cn>,
"Rosen Penev" <rosenp@gmail.com>, "Fan Wu" <fanwu01@zju.edu.cn>,
"Marco Crivellari" <marco.crivellari@suse.com>,
"Pan Chuang" <panchuang@vivo.com>,
"Zhan Xusheng" <zhanxusheng1024@gmail.com>,
"Rakuram Eswaran" <rakuram.e96@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Runyu Xiao" <runyu.xiao@seu.edu.cn>,
"open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..."
<imx@lists.linux.dev>,
"open list:OMAP MMC SUPPORT" <linux-omap@vger.kernel.org>,
"moderated list:ARM/ACTIONS SEMI ARCHITECTURE"
<linux-actions@lists.infradead.org>,
"open list:TMIO/SDHI MMC DRIVER"
<linux-renesas-soc@vger.kernel.org>,
"open list:ARM/ARTPEC MACHINE SUPPORT"
<linux-arm-kernel@axis.com>
Cc: <vkoul@kernel.org>
Subject: Re: [PATCH 1/1] mmc: use dmaengine_desc_set_callback()
Date: Wed, 4 Nov 2026 13:55:13 +0200 [thread overview]
Message-ID: <027e79aa-1634-4389-a04d-25d4b5f229f7@intel.com> (raw)
In-Reply-To: <20261102172126.3890568-1-Frank.Li@oss.nxp.com>
On 02/11/2026 19:21, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper across MMC host drivers.
>
> No functional change intended. Prepare make to struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/mmc/host/atmel-mci.c | 3 +--
> drivers/mmc/host/bcm2835.c | 3 +--
> drivers/mmc/host/dw_mmc.c | 3 +--
> drivers/mmc/host/moxart-mmc.c | 3 +--
> drivers/mmc/host/mxcmmc.c | 3 +--
> drivers/mmc/host/mxs-mmc.c | 3 +--
> drivers/mmc/host/omap.c | 3 +--
> drivers/mmc/host/omap_hsmmc.c | 3 +--
> drivers/mmc/host/owl-mmc.c | 3 +--
> drivers/mmc/host/pxamci.c | 3 +--
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 6 ++----
> drivers/mmc/host/sdhci.c | 3 +--
> drivers/mmc/host/sh_mmcif.c | 6 ++----
> drivers/mmc/host/uniphier-sd.c | 3 +--
> drivers/mmc/host/usdhi6rol0.c | 3 +--
> 15 files changed, 17 insertions(+), 34 deletions(-)
>
[ ... ]
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index efb4c7742fe21..18aca84834fb6 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1298,8 +1298,7 @@ static int sdhci_external_dma_setup(struct sdhci_host *host,
> if (!desc)
> return -EINVAL;
>
> - desc->callback = NULL;
> - desc->callback_param = NULL;
> + dmaengine_desc_set_callback(desc, NULL, NULL, NULL);
>
> cookie = dmaengine_submit(desc);
> if (dma_submit_error(cookie))
For sdhci:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2026-11-04 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 17:21 Frank.Li
2026-11-03 16:43 ` Wolfram Sang
2026-11-04 1:58 ` Kunihiko Hayashi
2026-11-04 2:40 ` Shawn Lin
2026-11-04 11:55 ` Adrian Hunter [this message]
2026-11-04 18:18 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=027e79aa-1634-4389-a04d-25d4b5f229f7@intel.com \
--to=adrian.hunter@intel.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@bootlin.com \
--cc=aubin.constans@microchip.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=enelsonmoore@gmail.com \
--cc=fanwu01@zju.edu.cn \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hemanth.selam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jesper.nilsson@axis.com \
--cc=jh80.chung@samsung.com \
--cc=john.garry@linux.dev \
--cc=kernel@pengutronix.de \
--cc=lars.persson@axis.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mani@kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhiramat@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=panchuang@vivo.com \
--cc=pengpeng@iscas.ac.cn \
--cc=rakuram.e96@gmail.com \
--cc=rjui@broadcom.com \
--cc=rosenp@gmail.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=ulfh@kernel.org \
--cc=vkoul@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhanxusheng1024@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®