From: Yiwei Lin <s921975628@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
corbet@lwn.net, linux-doc@vger.kernel.org
Cc: hdegoede@redhat.com, srinivas.pandruvada@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: docs: Add description for missing options of link_power_management_policy
Date: Thu, 15 Jan 2026 14:55:55 +0800 [thread overview]
Message-ID: <0282b93c-7d14-48ce-9706-d92ffcb64811@gmail.com> (raw)
In-Reply-To: <d329da11-d33e-4f6d-bf1b-c2466ffb3165@infradead.org>
On 1/15/2026 2:34 PM, Randy Dunlap wrote:
> Hi,
>
> On 1/14/26 7:29 PM, Yiwei Lin wrote:
>> With the kernel update we have more different policy for SCSI
>> link power management. Add the corresponding description to
>> the file.
>>
>> Signed-off-by: Yiwei Lin <s921975628@gmail.com>
>> ---
>> .../scsi/link_power_management_policy.rst | 17 ++++++++++++++---
>> 1 file changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/scsi/link_power_management_policy.rst b/Documentation/scsi/link_power_management_policy.rst
>> index 64288dcf1..07fbfd937 100644
>> --- a/Documentation/scsi/link_power_management_policy.rst
>> +++ b/Documentation/scsi/link_power_management_policy.rst
>> @@ -5,13 +5,13 @@ Link Power Managent Policy
>> ==========================
>>
>> This parameter allows the user to set the link (interface) power management.
>> -There are 3 possible options:
>> +There are 6 possible options:
>>
> These table headings lines (the ===== lines) need to be as long or longer than
> the text. keep_firmware_settings and min_power_with_partial are longer than the
> headings ===== line.
> Please extend the Value column headings ===== line by one character (just
> replace a space by '=') to avoid these warnings:
>
> Documentation/scsi/link_power_management_policy.rst:26: ERROR: Malformed table.
> Text in column margin in table line 17.
>
Thanks for pointing that out. I just sent a V2 patch for the fix.
>> ===================== =====================================================
>> Value Effect
>> ===================== =====================================================
>> -min_power Tell the controller to try to make the link use the
>> - least possible power when possible. This may
>> +min_power Enable slumber mode(no partial mode) for the link to
>> + use the least possible power when possible. This may
>> sacrifice some performance due to increased latency
>> when coming out of lower power states.
>>
>> @@ -22,4 +22,15 @@ max_performance Generally, this means no power management. Tell
>> medium_power Tell the controller to enter a lower power state
>> when possible, but do not enter the lowest power
>> state, thus improving latency over min_power setting.
>> +
>> +keep_firmware_settings Do not change the current firmware settings for
>> + Power management. This is the default setting.
>> +
>> +med_power_with_dipm Same as medium_power, but additionally with
>> + Device-initiated power management(DIPM) enabled,
>> + as Intel Rapid Storage Technology(IRST) does.
>> +
>> +min_power_with_partial Same as min_power, but additionally with partial
>> + power state enabled, which may improve performance
>> + over min_power setting.
>> ===================== =====================================================
prev parent reply other threads:[~2026-01-15 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 3:29 Yiwei Lin
2026-01-15 6:34 ` Randy Dunlap
2026-01-15 6:55 ` Yiwei Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0282b93c-7d14-48ce-9706-d92ffcb64811@gmail.com \
--to=s921975628@gmail.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®