From: Soumya Negi <soumya.negi97@gmail.com>
To: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
julia.lawall@inria.fr, Andi Shyti <andi.shyti@kernel.org>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Soumya Negi <soumya.negi97@gmail.com>
Subject: [PATCH v3 3/5] staging: vme_user: Remove printk() in find_bridge()
Date: Thu, 19 Oct 2023 18:55:21 -0700 [thread overview]
Message-ID: <028725ebbc522f73c39f5b1ec4cc2bdbdf588971.1697763267.git.soumya.negi97@gmail.com> (raw)
In-Reply-To: <cover.1697763267.git.soumya.negi97@gmail.com>
Don't log error message in find_bridge(). The printk() triggers a
checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
It can't be replaced by dev_err() & using pr_err() is not helpful as it
doesn't give much context to the user. It is better to remove it.
Signed-off-by: Soumya Negi <soumya.negi97@gmail.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/vme_user/vme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index c36c2dc095c5..5efcdf15a068 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -62,7 +62,6 @@ static struct vme_bridge *find_bridge(struct vme_resource *resource)
return list_entry(resource->entry, struct vme_lm_resource,
list)->parent;
default:
- printk(KERN_ERR "Unknown resource type\n");
return NULL;
}
}
--
2.42.0
next prev parent reply other threads:[~2023-10-20 1:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 1:55 [PATCH v3 0/5] staging: vme_user: Remove printk's & clean up log messages Soumya Negi
2023-10-20 1:55 ` [PATCH v3 1/5] staging: vme_user: Replace printk() with dev_*() Soumya Negi
2023-10-20 1:55 ` [PATCH v3 2/5] staging: vme_user: Use __func__ instead of function name Soumya Negi
2023-10-20 1:55 ` Soumya Negi [this message]
2023-10-20 1:55 ` [PATCH v3 4/5] staging: vme_user: Remove NULL-checks Soumya Negi
2023-10-20 1:55 ` [PATCH v3 5/5] staging: vme_user: Use dev_err() in vme_check_window() Soumya Negi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028725ebbc522f73c39f5b1ec4cc2bdbdf588971.1697763267.git.soumya.negi97@gmail.com \
--to=soumya.negi97@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®