From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA35C77B7A for ; Thu, 1 Jun 2023 03:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231264AbjFADCM (ORCPT ); Wed, 31 May 2023 23:02:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjFADCF (ORCPT ); Wed, 31 May 2023 23:02:05 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A30124 for ; Wed, 31 May 2023 20:02:00 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vk-f9VS_1685588516; Received: from 30.97.48.255(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vk-f9VS_1685588516) by smtp.aliyun-inc.com; Thu, 01 Jun 2023 11:01:57 +0800 Message-ID: <02887eb0-e7e5-34b3-dbb4-a689b9dc233d@linux.alibaba.com> Date: Thu, 1 Jun 2023 11:01:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 1/6] erofs: convert erofs_read_metabuf() to erofs_bread() for xattr To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230601024347.108469-1-jefflexu@linux.alibaba.com> <20230601024347.108469-2-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230601024347.108469-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/1 10:43, Jingbo Xu wrote: > buf->inode is constant once initialized during erofs_buf's lifetime. > Thus call erofs_init_metabuf() and erofs_bread() separately to avoid > the repetition of assigning buf->inode when iterating xattrs. > > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang