From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E43352C35 for ; Tue, 21 Apr 2026 22:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808908; cv=none; b=ScJghoWblIQhV4RQL64CmSaqg7gfq7+316tFwZ02g2mJwrOD22kDieIKGn4wYk0U4aHr3QBCWjYw+UZWHr7/x/3yzp1akMteR16ejUHt1iwmu0CWAG95gn5cT7kx/MkBN+cbCgRDCIYRG0AlbBlUq92QL+jENJs5dIfST30I2vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776808908; c=relaxed/simple; bh=Ni2emDZHUT3ZFPskAmph4HwdB+pXcvb9empy5VSuXX4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=giUp6CqNdslf8ySZX1nxDuEQn1sDnAcQqfidBSB3HU0++d7aNVOUR8kpgD+v/kAT/B+ebsbCXkslsEY1x52Dudw9HX46z5UywBJLoRThYc4otIomayxXM45HYk8R2zDOGeBMoHhno0LuqnhPi48F2RjWS+nbWOiiJTPn4nrGbCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H6cSD5sZ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GWd4gynj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H6cSD5sZ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GWd4gynj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776808903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PFV0AQVcu3YAl0tYQcglaFwWX0QLOSqW8EZn+GtNSTo=; b=H6cSD5sZQfQJxHDYfPOS29Dfyo0nqIGdNids/gXBb9oMAAZTARRj7dLMd7m4zzASPokDmU QGaWkupisqN76HWAeh1ee8ToBfqHglCv2PDnzMwwm5AyhaKTbHLcMQINKTGDxNd0JaACGI NIVuKHRbJBGtjB+kTTPYtehY+d+GEn4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-qtQXdsE7Ma6OsGXmJXw4cw-1; Tue, 21 Apr 2026 18:01:42 -0400 X-MC-Unique: qtQXdsE7Ma6OsGXmJXw4cw-1 X-Mimecast-MFC-AGG-ID: qtQXdsE7Ma6OsGXmJXw4cw_1776808897 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43ea7a5da57so3712674f8f.1 for ; Tue, 21 Apr 2026 15:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776808897; x=1777413697; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PFV0AQVcu3YAl0tYQcglaFwWX0QLOSqW8EZn+GtNSTo=; b=GWd4gynjULrMkqNnvCvTt9XRynpYGHJhLCA+cQAFkT5ZTdELH1vraNUUXc8fHjrWVy RqT7TEm6wByELwEKZqHi1YdfdRuv9bOK/Gn5zCGO10g67Cj18dyrbnBIrIb83alxwAti C/JqfzBaH89SsjyOp8K75KHued/r3Yo6pFEHwe6G/bTUwnYvONZjF55njmDbeD9gupvE hiE8Si2SOKPGu51Ltmlacon+9xwSwkD+oHqH7NqGsUlkj4U0g14RRiFwNL3ryJxnHBYW C+gjOqs58/gZefEQ3eifJuj4UHRTPIGRnj831U9LBLN9SyJWgnCPHb3lMuNjDSlITuVJ sPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776808897; x=1777413697; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFV0AQVcu3YAl0tYQcglaFwWX0QLOSqW8EZn+GtNSTo=; b=shlegBdVmPmYrk2n1gmkXcuEHxJS8SFNlIjHWXCuDGu1rA+MSLiqeM9BBV8274EjuO Sb9Owi2AgfZLXeYVmkWew0I++P1iMjFYCASIHkePP7rb1WH1YYqzrWXvh9iQEuad1AiW T0v5veEA1vXAlsbTfGscjTCpazOO3bpbJ5zgSU1ymH5rObsMTJvqaZBE+67cBOT8ZsQG mjREXxZtMgPFlFyRMfWVuRS6EB2PSqJhzi5kXgrLZYxmd8KMVCrJqLqhc1DbjsImyIV3 1LLjSQhy46Z91iDak9cH74LQ5+uBGRKU5V7F2638f3cpvcWxuTUvbJJnyyr+sIFWmxF9 ceBQ== X-Gm-Message-State: AOJu0Yx1+6S4+XYewZbnHcE6zkKQwxm4A27PHM0zQexT/x2pg7jDWEtg fRdQUEsB/QyPGoe9cmJf0pMnaAkHKbkMgAeCTSPC+i0k2pndfMHtx2nG5mV3LcAQoFCFBruMecU 7JypuC8IfmzI2rKv2BMUfvg8hmm+uh/ap3d6f+O1szvOOiuOw1O9/TVbKQg35ZZv9nsw5MmlJTM 07uHMmtVMeNhOM0sOfQsYhxSP2GMtp+rlkCpwj4EQhhrM= X-Gm-Gg: AeBDievYaoLR3Ir5h3NkHLRRws3cjDWOm9qQbIBV269A7qBtiStGe5nzwgCobLdn1VS JAj43P364flVSLJZZI8UR8j/WLlorY6hbyaepx5QC33yRz7Z/TNB/nSehYHliMCritYuuZcX3Bv m/gXceBWL7OeXZ0rfFE07S390yMuV3WzPZ1lTLdoYMwZtxiv8vj//+up9cMw/CawGjxqTnnuUdc oSvI/f1NyuIS5X2jWoyJ5wkouR0zs/+I46jKV3PqtDGjwDXLCY1XFLJ/yM3//fyR8LZAL51fMaE QDeIt0AL4a5vSwRu5UYGppDczGnr1xWE2WM/ia3znxVRxfPqN4Zxw0P+fEaXaDk5l1K9KXc+/mN J6vlztvZAY2qZ/Ot8LkhMThjgRgGBUnSmKkOEvoMJ+JhH09nrQvuBgg== X-Received: by 2002:a05:6000:18a5:b0:43c:ff58:35c3 with SMTP id ffacd0b85a97d-43fe3dc818fmr31329467f8f.10.1776808896382; Tue, 21 Apr 2026 15:01:36 -0700 (PDT) X-Received: by 2002:a05:6000:18a5:b0:43c:ff58:35c3 with SMTP id ffacd0b85a97d-43fe3dc818fmr31329402f8f.10.1776808895818; Tue, 21 Apr 2026 15:01:35 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e3a174sm44697673f8f.18.2026.04.21.15.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 15:01:35 -0700 (PDT) Date: Tue, 21 Apr 2026 18:01:32 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , Gregory Price , linux-mm@kvack.org, virtualization@lists.linux.dev, Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang Subject: [PATCH RFC v3 07/19] mm: use __GFP_ZERO in vma_alloc_anon_folio_pmd Message-ID: <028a9602232ce76e2b207f730982ad3135897bc3.1776808210.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Convert vma_alloc_anon_folio_pmd() to pass __GFP_ZERO instead of zeroing at the callsite. Pass the exact fault address (not PMD-aligned) to vma_alloc_folio() to ensure the cache locality optimization in folio_zero_user() works correctly. The NUMA interleave index computation already shifts by PAGE_SHIFT + order, so the unmasked address gives the same result. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- mm/huge_memory.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 8e2746ea74ad..3f2a868cf9e9 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1256,11 +1256,11 @@ EXPORT_SYMBOL_GPL(thp_get_unmapped_area); static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, unsigned long addr) { - gfp_t gfp = vma_thp_gfp_mask(vma); + gfp_t gfp = vma_thp_gfp_mask(vma) | __GFP_ZERO; const int order = HPAGE_PMD_ORDER; struct folio *folio; - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); + folio = vma_alloc_folio(gfp, order, vma, addr); if (unlikely(!folio)) { count_vm_event(THP_FAULT_FALLBACK); @@ -1279,14 +1279,6 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, } folio_throttle_swaprate(folio, gfp); - /* - * When a folio is not zeroed during allocation (__GFP_ZERO not used) - * or user folios require special handling, folio_zero_user() is used to - * make sure that the page corresponding to the faulting address will be - * hot in the cache after zeroing. - */ - if (user_alloc_needs_zeroing()) - folio_zero_user(folio, addr); /* * The memory barrier inside __folio_mark_uptodate makes sure that * folio_zero_user writes become visible before the set_pmd_at() -- MST