From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: "Shawn Guo" <shawnguo@kernel.org>,
"Martin Kaiser" <martin@kaiser.cx>,
"Clément Péron" <peron.clem@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks
Date: Mon, 5 Nov 2018 10:58:30 +0200 [thread overview]
Message-ID: <0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com> (raw)
In-Reply-To: <20181104144614.GJ26016@tiger>
Adding Clément.
On 11/04/2018 04:46 PM, Shawn Guo wrote:
> On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
>> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
>> function blocks. Add their ipg and per clocks to the device tree.
>>
>> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
>
> Are these EPIT devices actually used in upstream kernel, or just
> somewhere else?
Clément wrote a good driver, which has already passed a series of reviews,
but this clocks add-on is actually missing.
Clément, can you please add clock-names property and the corresponding
functional change to your driver? Thank you in advance.
--
Best wishes,
Vladimir
>> ---
>>
>> I tried to make this similar to gpt1 and gpt2.
>>
>> arch/arm/boot/dts/imx25.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
>> index b25309d26ea5..e80101847aff 100644
>> --- a/arch/arm/boot/dts/imx25.dtsi
>> +++ b/arch/arm/boot/dts/imx25.dtsi
>> @@ -388,12 +388,16 @@
>> epit1: timer@53f94000 {
>> compatible = "fsl,imx25-epit";
>> reg = <0x53f94000 0x4000>;
>> + clocks = <&clks 83>, <&clks 43>;
>> + clock-names = "ipg", "per";
>> interrupts = <28>;
>> };
>>
>> epit2: timer@53f98000 {
>> compatible = "fsl,imx25-epit";
>> reg = <0x53f98000 0x4000>;
>> + clocks = <&clks 84>, <&clks 43>;
>> + clock-names = "ipg", "per";
>> interrupts = <27>;
>> };
>>
>> --
>> 2.1.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-11-05 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 17:32 Martin Kaiser
2018-11-01 21:19 ` Vladimir Zapolskiy
2018-11-04 14:46 ` Shawn Guo
2018-11-05 8:58 ` Vladimir Zapolskiy [this message]
2018-11-05 13:55 ` Clément Péron
2018-11-05 9:12 ` Martin Kaiser
2018-11-13 14:42 ` Shawn Guo
2018-11-13 14:59 ` Clément Péron
2018-11-14 3:04 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome