From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F134AC433E1 for ; Sat, 11 Jul 2020 11:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9FCE20725 for ; Sat, 11 Jul 2020 11:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728228AbgGKLKT (ORCPT ); Sat, 11 Jul 2020 07:10:19 -0400 Received: from smtprelay0109.hostedemail.com ([216.40.44.109]:58056 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726523AbgGKLKT (ORCPT ); Sat, 11 Jul 2020 07:10:19 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 22C46100E7B42; Sat, 11 Jul 2020 11:10:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: day58_420072326ed6 X-Filterd-Recvd-Size: 3571 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Sat, 11 Jul 2020 11:10:15 +0000 (UTC) Message-ID: <02995ace8cc4524d44bf6e6db0282391c3f6d8e4.camel@perches.com> Subject: Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K: From: Joe Perches To: Jesper Dangaard Brouer Cc: "Alexander A. Klimov" , ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, mchehab+huawei@kernel.org, robh@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Date: Sat, 11 Jul 2020 04:10:13 -0700 In-Reply-To: <20200711102318.28ce29d6@carbon> References: <87tuyfi4fm.fsf@toke.dk> <20200710190407.31269-1-grandmaster@al2klimov.de> <28a81dfe62b1dc00ccc721ddb88669d13665252b.camel@perches.com> <20200711102318.28ce29d6@carbon> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-07-11 at 10:23 +0200, Jesper Dangaard Brouer wrote: > On Fri, 10 Jul 2020 12:37:47 -0700 > Joe Perches wrote: > > > On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote: > > > Rationale: > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465" > > > which has nothing to do with XDP. > > > > > > Signed-off-by: Alexander A. Klimov > > > --- > > > Better? > > > > > > MAINTAINERS | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 1d4aa7f942de..735e2475e926 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -18708,8 +18708,8 @@ F: include/trace/events/xdp.h > > > F: kernel/bpf/cpumap.c > > > F: kernel/bpf/devmap.c > > > F: net/core/xdp.c > > > -N: xdp > > > -K: xdp > > > +N: (?:\b|_)xdp > > > +K: (?:\b|_)xdp > > > > Generally, it's better to have comprehensive files lists > > rather than adding name matching regexes. > > I like below more direct matching of the files we already know are XDP > related. The pattern match are meant to catch drivers containing XDP > related bits. That's what the K: entry is for no? Anyway, if you agree with using the appropriate F: patterns, please submit it. I'm not going to. > (small typo in your patch below) > > > Perhaps: > > --- > > MAINTAINERS | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 16854e47e8cb..2e96cbf15b31 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -18763,13 +18763,19 @@ M: John Fastabend > > L: netdev@vger.kernel.org > > L: bpf@vger.kernel.org > > S: Supported > > -F: include/net/xdp.h > > +F: Documentation/networking/af_xdp.rst > > +F: include/net/xdp* > > F: include/trace/events/xdp.h > > +F: include/uapi/linux/if_xdp.h > > +F: include/uapi/linux/xdp_diag.h > > F: kernel/bpf/cpumap.c > > F: kernel/bpf/devmap.c > > F: net/core/xdp.c > > -N: xdp > > -K: xdp > > +F: net/xdp/ > > +F: samples/bpf/xdp* > > +F: tools/testing/selftests/bfp/*xdp* > ^^^^ > Typo, should be "bpf" > > > +F: tools/testing/selftests/bfp/*/*xdp* > > +K: (?:\b|_)xdp(?:\b|_) > > > > XDP SOCKETS (AF_XDP) > > M: Björn Töpel > > > >