From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdI0U3B (ORCPT ); Wed, 27 Sep 2017 16:29:01 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40755 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdI0U27 (ORCPT ); Wed, 27 Sep 2017 16:28:59 -0400 Subject: Re: [PATCH v2 2/2] sparc64: Use lzcnt instruction for fls and __fls To: Sam Ravnborg Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, babu.moger@oracle.com, rob.gardner@oracle.com References: <1506540326-9604-1-git-send-email-vijay.ac.kumar@oracle.com> <1506540326-9604-3-git-send-email-vijay.ac.kumar@oracle.com> <20170927195637.GB15193@ravnborg.org> From: Vijay Kumar Organization: Oracle Corporation Message-ID: <029daf33-40f3-97be-e9f5-3fb0a48f3be5@oracle.com> Date: Wed, 27 Sep 2017 15:29:30 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170927195637.GB15193@ravnborg.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, On 9/27/2017 2:56 PM, Sam Ravnborg wrote: >> .size niagara4_patch_pageops,.-niagara4_patch_pageops >> + >> + .globl niagara4_patch_fls >> + .type niagara4_patch_fls,#function >> +niagara4_patch_fls: >> + NG_DO_PATCH(fls, NG4fls) >> + NG_DO_PATCH(__fls, __NG4fls) >> + retl >> + nop >> + .size niagara4_patch_fls,.-niagara4_patch_fls > Please path the remaining functions in this file with ENTRY(), ENDPROC() - in a separate patch. Thanks for your comment. Sure, I will make the changes and address other comments as well in my revised version. - Vijay