mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>,
	Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH ath-next v2 0/2] wifi: ath12k: refactor m3/aux_uc firmware memory handling
Date: Wed, 4 Nov 2026 14:53:18 +0800	[thread overview]
Message-ID: <029eac4d-9516-44eb-922f-73ebce894925@oss.qualcomm.com> (raw)
In-Reply-To: <20261104-m3_and_aux_ucode-v2-0-b6c335c14dfe@oss.qualcomm.com>



On 11/4/2026 2:30 PM, Madhavan Ganesan wrote:
> ath12k_qmi_m3_free()/ath12k_qmi_m3_load() and
> ath12k_qmi_aux_uc_free()/ath12k_qmi_aux_uc_load() carry near-identical
> logic for freeing a DMA-coherent firmware memory region and loading
> firmware into it. Factor the shared logic into common helpers.
> 
> Patch 1 is a preparatory, no-functional-change rename of
> struct m3_mem_region to struct ath12k_fw_mem_region, since the type
> is also used for the aux_uc region and the old name no longer
> reflects its purpose.
> 
> Patch 2 refactors the shared free/load logic into
> ath12k_qmi_free_mem_region() and ath12k_qmi_fw_mem_load(), and
> rewires the m3 and aux_uc wrappers to use them.
> 
> ---
> Changes in v2:
> - Addressed the review comments.

this is not enough: you need to clearly state what are changed in each patch.

And I already gave my Reviewed-by: in v1 review, any reason why you didn't carry it in
this post? I don't see any major difference between this and the previous revision.

  parent reply	other threads:[~2026-11-04  6:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  6:30 Madhavan Ganesan
2026-11-04  6:30 ` [PATCH ath-next v2 1/2] wifi: ath12k: rename m3_mem_region to ath12k_fw_mem_region Madhavan Ganesan
2026-11-04  6:30 ` [PATCH ath-next v2 2/2] wifi: ath12k: refactor m3 and aux_uc firmware memory handling Madhavan Ganesan
2026-11-04 17:52   ` Jeff Johnson
2026-11-04  6:53 ` Baochen Qiang [this message]
2026-11-04  7:10   ` [PATCH ath-next v2 0/2] wifi: ath12k: refactor m3/aux_uc " Madhavan Ganesan
2026-11-04  7:15     ` Baochen Qiang
2026-11-04  7:15 ` Baochen Qiang
2026-11-04  7:24 ` Vasanthakumar Thiagarajan
2026-11-04 18:59 ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=029eac4d-9516-44eb-922f-73ebce894925@oss.qualcomm.com \
    --to=baochen.qiang@oss.qualcomm.com \
    --cc=ath12k@lists.infradead.org \
    --cc=jjohnson@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=madhavan.ganesan@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®