From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdGRJXn (ORCPT ); Tue, 18 Jul 2017 05:23:43 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:46229 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbdGRJXl (ORCPT ); Tue, 18 Jul 2017 05:23:41 -0400 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="2317729" Subject: Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout To: Lee Jones , Ludovic Desroches CC: , , , , , , References: <20170711074015.30440-1-ludovic.desroches@microchip.com> <20170711074015.30440-3-ludovic.desroches@microchip.com> <20170718081508.yo6uld5ip5hr6ipk@dell> <20170718091238.wweaobzccdlgv5dh@dell> From: Nicolas Ferre Organization: microchip Message-ID: <02a0c390-610c-d38b-e6a3-f04120c6fbb3@microchip.com> Date: Tue, 18 Jul 2017 11:23:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170718091238.wweaobzccdlgv5dh@dell> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/07/2017 at 11:12, Lee Jones wrote: > On Tue, 18 Jul 2017, Lee Jones wrote: > >> On Tue, 11 Jul 2017, Ludovic Desroches wrote: >> >>> For HSMC controller, the register layout depends on the device i.e. the >>> offset of setup, pulse, cycle, mode and timings registers is not the >>> same. An helper is added to provide the correct register layout. >>> >>> Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease >>> SMC regs manipulation") >>> Suggested-by: Boris Brezillon >>> Signed-off-by: Ludovic Desroches >>> --- >>> drivers/memory/atmel-ebi.c | 13 +++++-- >>> drivers/mfd/atmel-smc.c | 67 +++++++++++++++++++++++++------- >>> drivers/mtd/nand/atmel/nand-controller.c | 10 +++-- >>> include/linux/mfd/syscon/atmel-smc.h | 32 ++++++++++----- >>> 4 files changed, 92 insertions(+), 30 deletions(-) >> >> Applied, thanks. > > Apologies, it looks like this needs 2 more Acks before I can even > consider taking it. > > Unapplied. If mine is missing, here it is: For the whole series: Acked-by: Nicolas Ferre And I think that Alexandre seemed okay by discussing the path those patches should take... Thanks, bye, -- Nicolas Ferre