From: Dave Jiang <dave.jiang@intel.com>
To: Gregory Price <gourry@gourry.net>, Vishal Aslot <vaslot@nvidia.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Li Ming <ming.li@zohomail.com>,
Peter Zijlstra <peterz@infradead.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Zijun Hu <zijun.hu@oss.qualcomm.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/hdm: allow zero sized committed decoders
Date: Thu, 2 Oct 2025 08:32:35 -0700 [thread overview]
Message-ID: <02a4b5f1-ad29-4825-9040-ff96e328f674@intel.com> (raw)
In-Reply-To: <aN4SSEmaCaxbeiwJ@gourry-fedora-PF4VCD3F>
On 10/1/25 10:48 PM, Gregory Price wrote:
> On Wed, Oct 01, 2025 at 08:37:26PM +0000, Vishal Aslot wrote:
>> @@ -1210,6 +1210,11 @@ int devm_cxl_enumerate_decoders(struct cxl_hdm *cxlhdm,
>> rc = init_hdm_decoder(port, cxld, target_map, hdm, i,
>> &dpa_base, info);
>> if (rc) {
>> + if (rc == -ENOSPC) {
>> + put_device(&cxld->dev);
>> + rc = 0;
>> + continue;
>> + }
>
> How do you suggest actually testing this? I briefly poked at this in
> QEMU trying to commit decoders, but i found myself incapable of
> exercising this path.
It may be worthwhile adding a cxl_test test case for this.
>
>> dev_warn(&port->dev,
>> "Failed to initialize decoder%d.%d\n",
>> port->id, i);
>> --
>> 2.34.1
next prev parent reply other threads:[~2025-10-02 15:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 20:37 Vishal Aslot
2025-10-01 21:28 ` Dave Jiang
2025-10-01 22:03 ` Vishal Aslot
2025-10-01 22:46 ` Dave Jiang
2025-10-02 1:57 ` Vishal Aslot
2025-10-03 0:59 ` [PATCH v2] " Vishal Aslot
2025-10-03 4:28 ` Gregory Price
2025-10-04 13:30 ` Vishal Aslot
2025-10-03 16:20 ` Dave Jiang
2025-10-03 20:02 ` Vishal Aslot
2025-10-04 0:06 ` Davidlohr Bueso
2025-10-04 13:34 ` Vishal Aslot
2025-10-02 5:48 ` [PATCH] " Gregory Price
2025-10-02 15:32 ` Dave Jiang [this message]
2025-10-03 1:03 ` Vishal Aslot
2025-10-03 14:23 ` Gregory Price
2025-10-04 13:49 ` Vishal Aslot
2025-10-06 17:06 ` Gregory Price
2025-10-03 16:14 ` Dave Jiang
2025-10-04 14:05 ` Vishal Aslot
2025-10-06 14:54 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a4b5f1-ad29-4825-9040-ff96e328f674@intel.com \
--to=dave.jiang@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.li@zohomail.com \
--cc=peterz@infradead.org \
--cc=vaslot@nvidia.com \
--cc=vishal.l.verma@intel.com \
--cc=zijun.hu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®