From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755735AbdJQBr3 (ORCPT ); Mon, 16 Oct 2017 21:47:29 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:38934 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbdJQBr2 (ORCPT ); Mon, 16 Oct 2017 21:47:28 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <36a4106207778ed80d1b7d5d171b49d9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface To: Sandy Huang , David Airlie , Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1507536396-106827-1-git-send-email-hjc@rock-chips.com> <1507536416-110807-1-git-send-email-hjc@rock-chips.com> From: Mark yao Message-ID: <02a599df-c866-92dc-3aa0-f63c6bc67257@rock-chips.com> Date: Tue, 17 Oct 2017 09:47:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1507536416-110807-1-git-send-email-hjc@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年10月09日 16:06, Sandy Huang wrote: > Some Rockchip CRTCs, like rv1108, can directly output parallel and > serial RGB data to panel or conversion chip, so we add this driver to > probe encoder and connector. > > Signed-off-by: Sandy Huang > --- > Changes in v3: > update for rgb-mode move to panel node. > Changes in v2: > 1. add error log when probe failed; > 2. update name_to_output_mode() according to sean's suggest; > 3. Fix uninitialized use of ret. > > drivers/gpu/drm/rockchip/Kconfig | 9 + > drivers/gpu/drm/rockchip/Makefile | 1 + > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 + > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + > drivers/gpu/drm/rockchip/rockchip_rgb.c | 343 ++++++++++++++++++++++++++++ > 5 files changed, 356 insertions(+) > create mode 100644 drivers/gpu/drm/rockchip/rockchip_rgb.c > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index 0c31f0a..85c7cc5 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -8,6 +8,7 @@ config DRM_ROCKCHIP > select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP > select DRM_DW_HDMI if ROCKCHIP_DW_HDMI > select DRM_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI > + select DRM_RGB if ROCKCHIP_RGB > select SND_SOC_HDMI_CODEC if ROCKCHIP_CDN_DP && SND_SOC > help > Choose this option if you have a Rockchip soc chipset. > @@ -65,4 +66,12 @@ config ROCKCHIP_LVDS > Rockchip rk3288 SoC has LVDS TX Controller can be used, and it > support LVDS, rgb, dual LVDS output mode. say Y to enable its > driver. > + > +config ROCKCHIP_RGB > + bool "Rockchip RGB support" See the fix[0] for lvds, RGB driver using pinctl also need "depends on PINCTRL". [0]https://patchwork.kernel.org/patch/9987017/