From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbdAZVyE (ORCPT ); Thu, 26 Jan 2017 16:54:04 -0500 Received: from mout.web.de ([212.227.17.11]:51287 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753754AbdAZVx7 (ORCPT ); Thu, 26 Jan 2017 16:53:59 -0500 Subject: [PATCH 2/3] virtio_pci: Use kmalloc_array() in vp_request_msix_vectors() To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" References: <61829748-a13d-42e4-8f6c-103ee5ca2c88@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <02a6f5e2-d20b-3e71-5eaa-344331bec7f1@users.sourceforge.net> Date: Thu, 26 Jan 2017 22:46:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <61829748-a13d-42e4-8f6c-103ee5ca2c88@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jrogEwSy+BOg/nDhTNoXpXxkcEncfxUBo9yKIzBcY342tIvGQS9 Vdlnrmfi4bJw1Upxifce2vhqbh5VohkoOuas7goE6Rl3zO3VoVVVrld5PlOc24QTwju7znv S4MWsaMNBVfJgNSbaRBdKCCorRMKX8dCIt8nkFYtZAo/HyNFdJPQoZQpLrQj3MMPM4pkGo5 Lq8UjACkbRcZTlGZiD8Fw== X-UI-Out-Filterresults: notjunk:1;V01:K0:v7bzGxpt/go=:3JXJD7fLH7SJEhXlBXxe4M ylP/2V1C5/yITuXJxIysfvewsDiw9LRgSB/rz1iILh6MIld0dHrls3W4V1KqBo9/Ne3JADNAI QVoLvJDwcEnRgzkXJa2w3V/HNKRl3Fm5DiUAfxnsAE8mPjUTOlnfebRgwdqvIF3fAuXdoiENf 9Q9K+tSScfgY8mKcTDIBGfSZfmm2jchSkspssYVy7AiP03Tpx5vHQKK3gfqcIgkNbtutV8Xxw RApEFfYs9CvaUpWgNAM3lQZY8S+Lsa9hkdZ7Nagvcr24j6q/bDu5gCs1ptPzqffmuXuKCaQiK 1iBtuLAEdNf0cZIMT3N/zvK6NMy77RjCqyx/O4Bi9EE2jPe8XQgfGBSqM50gZcdsddud6HVBz nQP95HgBgZztFO+W24hzODfQtfYmlcmE9UCUqOBYAqmQPe/gLJgJm/8Fc9yI35bfv5yNQj/C6 nKphZ3ofna7luhGtvxkdfNefxuhues6pq0U5SAguCU9hfj+zvuvor3yrZstB0c/mSGunkUDRK HjV/dweZRX44YryU3nAwsxFyKEpBCpeeznMaHEzs58ffXbkV5pQbIqpbwCumkyMigQh8ZhfnB 9MQElIBCKU2/JXSGVzxTsnKAE4qlAzNx5vt016TXlmscEeESrAtpMH9e+0DpCgCPV1vpgQNqa 5vLT3qH9oBS7HAodcffXLzcIGoicVRyeZX4ZjFx2wSxcqFLaPtncfZVo8Wjbo7qF/e5c7Pdmh r9tDaiw9IJ/3JAfdhKBBQBQ0EY+lUPc0aN+KM94om9B4Bv3VA5UWmtXm1PpQ9xgshEJu2sKXz 0NNQJj1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 26 Jan 2017 22:20:30 +0100 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/virtio/virtio_pci_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index 559a2b706093..623a8cea1441 100644 --- a/drivers/virtio/virtio_pci_common.c +++ b/drivers/virtio/virtio_pci_common.c @@ -111,9 +111,9 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, int err = -ENOMEM; vp_dev->msix_vectors = nvectors; - - vp_dev->msix_names = kmalloc(nvectors * sizeof *vp_dev->msix_names, - GFP_KERNEL); + vp_dev->msix_names = kmalloc_array(nvectors, + sizeof(*vp_dev->msix_names), + GFP_KERNEL); if (!vp_dev->msix_names) goto error; vp_dev->msix_affinity_masks -- 2.11.0