From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F1A43CEF8 for ; Mon, 18 May 2026 13:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779109625; cv=none; b=btX24hu6DsjMaJccugq6R2lSDW30pqHqWFya3gB5/d3Cujcure1TpneMMc4Fw47DjOtz2DNJvfhNlq9p4sH/R/UJKkbUhbhnUhgzwgG6SJZRPW/U2Y7OJ9AkV96SXPdUZeEwT5HJfXqwE3ZnDwpgrtHN1SEW6SWU7VzU5DiAGA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779109625; c=relaxed/simple; bh=Ya02RhlqEZpt7PO2wzq7RoXZ3jq5BLY2qWaxfoLcUG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EQsnfHGGSJPuSYSHiwVtgi1nYUHrlB9VhYjyCx8C3lvVu/UF7zReyL7RY9F00hWWZ372U9hdmzzXUFRwIgwRN9x+iJ8y//xMJo8By/YuKW/bk3cmOSwa2/bSpzG6Fa0Afb9HZJ7EEEz1q6d0qDU+fODzg0Vi04KjqCx7Uc4KXi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SZjmHy9y; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SZjmHy9y" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-38e800deae4so22965591fa.0 for ; Mon, 18 May 2026 06:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779109620; x=1779714420; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vUiMRRSmY+S3AmG7AOP23s7PvAi6QEqj5i/lCE5ZaFI=; b=SZjmHy9yKIvkTmQ4HMkgRX7Wv10JqQHA9wJi2Z6tlqVzrh1M58B0QMt4f27EArepy6 eTqUMHA80581sUiSe4j6U7OskACtRSUA8jnvz3IFl+W/b1Wjr2ZLmoRrMv/K95v0mhJT MzQTkae7EBaZnT0MagNsy6mF2AhI5j5G/7KC2BelW2wmwIFVqvLqSvxC82Fzbjr2Gdgt cqfyb8XGMEJe23f8v/bDMbNhMDmHjUufbSL3F2kBUzjwBuj0kybWxGMu4SYXk5h4vQvu kBxCjv3HetS4By+3tb5FDrHxgPt9Q36Kgj0CdMmC3doBfFPX9xSXLZSMjRykee+Sjc6U D0dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779109620; x=1779714420; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vUiMRRSmY+S3AmG7AOP23s7PvAi6QEqj5i/lCE5ZaFI=; b=k/FIP3LyWNvXqqkgXq7x13mwbtiEFYfy0IzXzmSohuYpJCKvJtDw+TOsORVaJWMMPQ ydugSCTjZwAciR+CdOfTPY/frRuTCGV+V3A4nQfEBxJJ26EMW9dcvRF1TLhSqFTXpeRL HKatuWz7AhGf61ZWFHw1rghWysv2nTYHa/u8LfyVNu5Uw6EFIOtDoBz37ZnxaE4qHvhd jNZALXnnY+DP4br8s+3gjfrEu4VEj/64eVkz6PaEoen1QrqkgpN3fc+Zvxyd8Nnqr13j TzGK09FAYr13Ypx6xqzpcMC+w4OSJJQSc1sMGVgp7q8fjCDU4dv0ejmp5Wy4EfnddxaC 1q4Q== X-Forwarded-Encrypted: i=1; AFNElJ8X+z1+DNvY8+hKUH0Oq2t2nnRF242lNh4OalRHGxNEQLHhDWdQYGjnckeI7lu/Q/xG5DB1hs5fzm6Uaic=@vger.kernel.org X-Gm-Message-State: AOJu0YxHByAajdM8FZKgtrnURK4vjUuX9qZjvauWc9ZeO/02no3/US+y mntR+FHCDkV1hm3oOjXt0JWwruYloao+bGghld2ppORiAzoNk8SCYLmm X-Gm-Gg: Acq92OEpHQuS4DgZopyzdipCPiQSN1kmI2id23hYNjtnindw6hr82FN9OdH/thAmD5g ogMWe0yK/III2FIvCQgNRdNolaSNOT3q14dUO928Tr2O4tXECaj7VNpq9GuDr0g80XnZrqtF1CT njTpnITDZGEgDcMtHTkKCfqMmlj1k1XV+rx7e0An6dkH/r0135okP8KQfU0lvGpqwyIMp1E6/lN LS7Qu9OGGdfbAQu7ezhrTqrNw8ispj9JjGPVPlr77uVVRQiKyVi/UkaLIc4ygL99alAvNh2w+jO qlTGFQHQL4tSTQ3Ql6hHeJxr23tr2J8QoITN0g9reFJwohQJEy5Zr/KKrHjPEREebmOhwNQGL0j 9q5tPiSJG++esFXIqgsciYKzMoENczf1SBN3dfZLeqGb1/Dql1UcmFkv5lFdgWgNE5e2/3ARc0J YMpxnVrDYWSlzRtMwNFokQa2ZFfxv7t8QW X-Received: by 2002:a05:651c:41d7:b0:38b:e6c7:2c4d with SMTP id 38308e7fff4ca-39561c68693mr44652781fa.12.1779109619856; Mon, 18 May 2026 06:06:59 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395882c41c1sm11742241fa.12.2026.05.18.06.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 06:06:59 -0700 (PDT) Message-ID: <02a983b5-3527-4dfe-b8b3-55b5435f1c9e@gmail.com> Date: Mon, 18 May 2026 16:06:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: pressure: rohm-bm1390: notify trigger on all error paths To: Stepan Ionichev , jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260517160801.269-1-sozdayvek@gmail.com> <20260518094238.1986-1-sozdayvek@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260518094238.1986-1-sozdayvek@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/05/2026 12:42, Stepan Ionichev wrote: > bm1390_trigger_handler() returns from three error paths without > calling iio_trigger_notify_done(). The success path at the end > does, so on a single transient regmap or read failure the trigger > use_count is never decremented, and the !atomic_read(&trig->use_count) > guard in iio_trigger_poll_chained() drops every subsequent dispatch. > The buffered-data flow stays wedged until the trigger is detached. > I still believe the use-count should be decremented by the IIO, after it has called trigger handlers. (Unless there is an use-case where the use-count is not decremented.) Well, let's wait for a little while so Jonathan & others have time to comment. I have been wrong at times ;) > Funnel all returns through a single done label that calls > iio_trigger_notify_done() and reports the outcome via IRQ_RETVAL(). > > Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390") > Cc: stable@vger.kernel.org > Signed-off-by: Stepan Ionichev > --- > v2: > - Use a bool and IRQ_RETVAL() instead of irqreturn_t (Andy) > > v1: https://lore.kernel.org/all/20260517160801.269-1-sozdayvek@gmail.com/ > > drivers/iio/pressure/rohm-bm1390.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/pressure/rohm-bm1390.c b/drivers/iio/pressure/rohm-bm1390.c > index 08146ca0f..81368e578 100644 > --- a/drivers/iio/pressure/rohm-bm1390.c > +++ b/drivers/iio/pressure/rohm-bm1390.c > @@ -626,12 +626,15 @@ static irqreturn_t bm1390_trigger_handler(int irq, void *p) > struct iio_poll_func *pf = p; > struct iio_dev *idev = pf->indio_dev; > struct bm1390_data *data = iio_priv(idev); > + bool handled = true; I would inverse the logic. At this point, the IRQ is _not_ handled. Hence I'd default this false and only toggled it to true when the IRQ is indeed successfully acked and data is read. That should allow you to touch the 'handled' only once after the initialization. > int ret, status; > > /* DRDY is acked by reading status reg */ > ret = regmap_read(data->regmap, BM1390_REG_STATUS, &status); > - if (ret || !status) > - return IRQ_NONE; > + if (ret || !status) { > + handled = false; > + goto done; > + } > > dev_dbg(data->dev, "DRDY trig status 0x%x\n", status); > > @@ -639,7 +642,8 @@ static irqreturn_t bm1390_trigger_handler(int irq, void *p) > ret = bm1390_pressure_read(data, &data->buf.pressure); > if (ret) { > dev_warn(data->dev, "sample read failed %d\n", ret); > - return IRQ_NONE; > + handled = false; > + goto done; > } > } > > @@ -648,15 +652,16 @@ static irqreturn_t bm1390_trigger_handler(int irq, void *p) > &data->buf.temp, sizeof(data->buf.temp)); > if (ret) { > dev_warn(data->dev, "temp read failed %d\n", ret); > - return IRQ_HANDLED; > + goto done; > } > } > > iio_push_to_buffers_with_ts(idev, &data->buf, sizeof(data->buf), > data->timestamp); > +done: > iio_trigger_notify_done(idev->trig); > > - return IRQ_HANDLED; > + return IRQ_RETVAL(handled); > } > > /* Get timestamps and wake the thread if we need to read data */ Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~