From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 583662F25F3 for ; Thu, 23 Apr 2026 13:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776951959; cv=none; b=Xnv/15+qZvrj1tOFE3r4LCjr4OutCaPNPWdG8En2Mw7A4gh7AaX0KAL1046o2QsnNENnvUAVKOt3rrQHLPPnIw+b60K3Uifjs4JH+JYdyILe87RX7uC/JvnElVG5Fe7SomiV8nyENGpWJNmqaIAhBqSSZ9pAk8Ts12yOWkVjVcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776951959; c=relaxed/simple; bh=t8OdP5Wa+Cr183kt5xldZxgitUy8mPnBLL1Bn+JTfTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ok4pdo7QsFp4PPvH4Tv9T3awBWIZmI0XenROTBh/343y/NFG/24cl9SCiXK3pGE17tILsfSwme8r+oIvNudwyc8XawVuFsuaVx9R/ShZ8ObePVF+pOqpJ6tOAyBQWGWoNfVNoMlsO1z3WZoDBKKjxqhqmW9M7/iZCnmxtQgvBCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UXMWzFJp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EOUZa5op; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UXMWzFJp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EOUZa5op" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8u4FF3769001 for ; Thu, 23 Apr 2026 13:45:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UR95r8BAMJZnQFiE6CybGBBNNYv6tUewEHhmeWr7AG8=; b=UXMWzFJpGZujc3Mc pM9xI33WArrVgXPdAtSVbwU4buGK0LPIP+9M2N3iBAqWVV2efs/CTgH9VAis85aQ 073/Gz+L5Ctw+yA1LDRJ+j9hUR/byDJa1LsFTlazso4cIUA/5Bg4Pk2k6bqv7Zyc NXFb3Qvl069HyMT5wV448nDPelMNh+KFtkwzjttv82EWdjE70LhaD1XTGBEz+0ht SLjXdjbsWuJCuGw2e0E0l3naYPF2TuW5uozyT27yJJAw4tB2VRwB1+HJJ7AbLBIs hDxc75c4YDvTcQoVM5ziLt6rGGi3u0brFdHFEV7g+2duD9KofBy27yidjHX19X0g 32OtaQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1hq44d0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 13:45:54 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2adc527eaf5so53187825ad.0 for ; Thu, 23 Apr 2026 06:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776951954; x=1777556754; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UR95r8BAMJZnQFiE6CybGBBNNYv6tUewEHhmeWr7AG8=; b=EOUZa5op2Y5FhUwe8BgQavytVKLYjB2p2mzY7SmbW6ONTJuyy9Ohl/TR3A8OwqSG9h cT2Gb1e++FkdkclnT4iuAL491t0y42rJTO6m8ve8+kJpIhvM6LVsO/vBzD5H6EtI9m+u 8Qy8SeUT7V3Dw3ja8V+UDUJEuxFrXjyyxmSEila/EKnGGbnBs1+I4yHx/UnHEpFtBrz7 L3xtd9xzm6jaKvERVcVNqNCiFNMgFIVU9SE7Twsylm7+Q8HODazTjIArDIgCdCb8ZNbk B0Qw0GgArWrpjmP8FYNbjT2acSV1ap24z+xNx1TFgVcQNgAILbVtq+NJhabfNMy/J/5b CTtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776951954; x=1777556754; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UR95r8BAMJZnQFiE6CybGBBNNYv6tUewEHhmeWr7AG8=; b=nbjYkNzLckqlTD9iDTnrxZO/avNiq44JkCGJ1yOd4RlOVBxY0xO2FkdTShUmTZHAhF SeUUf3EfP0u058HyUpu0IHsdQMUyzLqh8mPw6JQvhrtoxIWC3B68cwQenpfAwxmpPIBa jgPLKXwuyiW0prpO35KQm4ZD/Y6TWd/5+4IeDdfLtgq0dgP0PMnbC1jt/wCam8jSGN58 6+jmKenVcCHS4jHuH+HzxPrwk5XpAgO2B/Bl837qmTmBMVa0tT+yb120gybB7E96WYy1 g7l6mVREqDtN4c+Ylqk2sn9/+a2Tt5TYEkObv3+AdhalccNlkRxpRpkYVg2OZXeQtiL2 9Tkw== X-Forwarded-Encrypted: i=1; AFNElJ9LjgXgfhVA5psRTQpcaf7IYcDlZKQWQcdqHVgqSUpCMpqtma6H4mI6WKvc60rQrnqeZVx6OU9/fkioMyw=@vger.kernel.org X-Gm-Message-State: AOJu0YyCvcPmDH0OJ97J5rv0HH/24RGmxgR0uuMIaDYep1j4QtyLYNss BsqDB1RvfDxw0ZLfcZcBPwyzcxQVCkZZCX4OHpp0sjc5dbseFCsUtnkzXTSKr2pfdZx/dTHd2pq us08xG1VNcfWveFEsWbD9+oLYo7C/ywsG+iYKO4OJQyeeTNMPSoDQlADPJFrqNUZr5j8= X-Gm-Gg: AeBDievUlEO8ueMPJrj5rzG4zqzABejDrqFpnCnwgjT+zBH09FAemelRq0PN+cwSWBI aN90wiEOsFkgM72h8FFGCnU6JiTOug8cwvW+ZQrdBm+dD67JhwHT28gyykraE2uEPfzBp9SKqB7 RnExIFHyvKcWgVt9CA92GSTG0ZTS9xa5SGKFGLOWUilht4gU4zwuf7XGH5bu15lbqSy4hJeKDj4 LGSB6JyQ6pOOXQs/GS/KmdX6y06sfxQJ718NZ4b5NKEdBDDFcFpvZqhBiqfzRqa0oZygMx8Sxk7 qMNK2liGR6urF2UOptCGhlSCOPtEkha7ZCfml7xai8Gi/UQZ69bCwgx4zKS8IPd8Yln8WSD0h5L lBQYy2xvyhkB+siHGvicjX2vKsKMyZO5W0JDpjvOuytJ8KZpR75PuvDU2JXFWbJnZvu4vQTf0nr l6S9hrsEJHN83KxZIiZ6LsKj1FIdbegalRR3xX1XzX4w== X-Received: by 2002:a17:903:98d:b0:2b0:b290:f2f4 with SMTP id d9443c01a7336-2b5f9f64965mr291583315ad.32.1776951953719; Thu, 23 Apr 2026 06:45:53 -0700 (PDT) X-Received: by 2002:a17:903:98d:b0:2b0:b290:f2f4 with SMTP id d9443c01a7336-2b5f9f64965mr291582845ad.32.1776951953195; Thu, 23 Apr 2026 06:45:53 -0700 (PDT) Received: from [10.79.135.26] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab0cbaasm199155325ad.54.2026.04.23.06.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 06:45:52 -0700 (PDT) Message-ID: <02ad9279-7bc5-49ca-86f1-a7c2cf79b91a@oss.qualcomm.com> Date: Thu, 23 Apr 2026 19:15:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: dwc: Initialize pp->lock before MSI domain registration To: Shawn Lin , jingoohan1@gmail.com, mani@kernel.org Cc: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260414065214.3085209-1-yadu.mg@oss.qualcomm.com> <68f9def1-5828-aa30-8887-4b6594595bad@rock-chips.com> Content-Language: en-US From: Yadu M G In-Reply-To: <68f9def1-5828-aa30-8887-4b6594595bad@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDEzNyBTYWx0ZWRfX4Q2DuXzeYplE 9nJ2pcw6dJSfOql7yOLgvErkAb10guj4/mRLuccZNT45H8xt+4ilQagNZu8r0IN/Yr993rZxIbv l3Enjzholl2gNUWhy8z0hnlYLykDChcBtAxIL/p063VPQ9Py/uhx2cEt5AJUYnQ9nVzBDenq5mO Qi3+ommnblsioNZ6LRYhhXaiex5WgFVSaRw9ApAYha++Wom4IXuQYQfVhmXWKb4Azp9fDl+o8TR O+NsvXMLSJ3+8WRq9XG9dhDcpJib0EvHGIsHhGOcnL4tzd5ZWcCCnotvXskbtvfBEopWzlXQ6dr lH/ovmHpbb5kDUyvCGhEkrkNtOVasiQouwtCkis9+fIBjPgLdUUtwL++EMXn5KTmvchXQ1Lw5DA nmCcxO8ZOdJA+bI1fDif8hveN6cHR5/YEocp1Mx1MVYlNGk18FMlABsjnYdywFbBLz/MjaeIbr8 KENIrZXkblboQKfi/ew== X-Proofpoint-ORIG-GUID: GN48lK3QGzwWtegFSpgys0G9otFoviuq X-Proofpoint-GUID: GN48lK3QGzwWtegFSpgys0G9otFoviuq X-Authority-Analysis: v=2.4 cv=TJt1jVla c=1 sm=1 tr=0 ts=69ea2292 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=5gdTzy6pTaml4LQ7KugA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230137 On 4/21/2026 6:52 AM, Shawn Lin wrote: > Moreover, sophgo_pcie_host_init() calls sophgo_pcie_msi_enable() which > need to acquires pp->lock with a uninitialized lock with your patch now. > That could possible break all other variant drivers which need this lock > in the .init() callback. > Agreed — pp->lock must be initialized even when MSI is disabled. I'll keep the init in dw_pcie_host_init() and add a one-time init in dw_pcie_allocate_domains() for direct callers, then resend. Thanks, Yadu