From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FC8C3A589 for ; Thu, 15 Aug 2019 23:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591472086C for ; Thu, 15 Aug 2019 23:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565911106; bh=iJhe6y6JGRGDCMzyg3rw4IDGMv4To3vHo/3eeEQyvLg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=HA93X3DnRODuKpqo89FUBaCAlDjwVzyb7EbnupWoACL5ck648iH58cRYG7Pa1Y3oz YCvmLytkV84WR+5Ar1HNxkuaFQhCirGI1uTl3b3kq6r7mQ8R5MDSNJOuWsDnvKncf+ NY1bK80zfKRBoF+QySRgbQ+dEWK/k4IzPl4wKeU0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387710AbfHOXSZ (ORCPT ); Thu, 15 Aug 2019 19:18:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732278AbfHOXSZ (ORCPT ); Thu, 15 Aug 2019 19:18:25 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8579E2083B; Thu, 15 Aug 2019 23:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565911104; bh=iJhe6y6JGRGDCMzyg3rw4IDGMv4To3vHo/3eeEQyvLg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IhO632crOR6eYMBweQJSP5H1+7IbfN4OwDJ7QF5x3ujTb3wWBdBrmZjEuNcjSeCtX ftNUKBS9Ixy+M6JqOL3m2kk2aj1OdwPmXzDucHzC3E5S+WMOuhLnB3dF0WlJdE9nvE 5ivGmIi1O+GhXuCbfop4x9HJxqBF19zvvO6kQJRc= Subject: Re: [PATCHv6 30/36] selftest/timens: Add Time Namespace test for supported clocks To: Dmitry Safonov , linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Adrian Reber , Andrei Vagin , Andy Lutomirski , Arnd Bergmann , Christian Brauner , Cyrill Gorcunov , "Eric W. Biederman" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jeff Dike , Oleg Nesterov , Pavel Emelyanov , Thomas Gleixner , Vincenzo Frascino , containers@lists.linux-foundation.org, criu@openvz.org, linux-api@vger.kernel.org, x86@kernel.org, shuah References: <20190815163836.2927-1-dima@arista.com> <20190815163836.2927-31-dima@arista.com> From: shuah Message-ID: <02add700-b626-a1b4-09e1-1e4d5cd242f2@kernel.org> Date: Thu, 15 Aug 2019 17:18:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190815163836.2927-31-dima@arista.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Thanks for the patch. On 8/15/19 10:38 AM, Dmitry Safonov wrote: > A test to check that all supported clocks work on host and inside > a new time namespace. Use both ways to get time: through VDSO and > by entering the kernel with implicit syscall. > > Introduce a new timens directory in selftests framework for > the next timens tests. > > Co-developed-by: Andrei Vagin > Signed-off-by: Andrei Vagin > Signed-off-by: Dmitry Safonov > --- > tools/testing/selftests/Makefile | 1 + > tools/testing/selftests/timens/.gitignore | 1 + > tools/testing/selftests/timens/Makefile | 5 + > tools/testing/selftests/timens/config | 1 + > tools/testing/selftests/timens/log.h | 26 +++ > tools/testing/selftests/timens/timens.c | 185 ++++++++++++++++++++++ > tools/testing/selftests/timens/timens.h | 63 ++++++++ > 7 files changed, 282 insertions(+) > create mode 100644 tools/testing/selftests/timens/.gitignore > create mode 100644 tools/testing/selftests/timens/Makefile > create mode 100644 tools/testing/selftests/timens/config > create mode 100644 tools/testing/selftests/timens/log.h > create mode 100644 tools/testing/selftests/timens/timens.c > create mode 100644 tools/testing/selftests/timens/timens.h > > diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile > index 25b43a8c2b15..6fc63b84a857 100644 > --- a/tools/testing/selftests/Makefile > +++ b/tools/testing/selftests/Makefile > @@ -47,6 +47,7 @@ TARGETS += splice > TARGETS += static_keys > TARGETS += sync > TARGETS += sysctl > +TARGETS += timens How long does this test run for? Does this test need to be run as root? If yes, please add a root check and skip the test. What does the test output looks like for skip and pass/fail cases? thanks, -- Shuah