From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82C5B3BBA1F for ; Wed, 8 Apr 2026 10:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775644354; cv=none; b=F4XurRydEUwNuTYUb1U4lwDpMJog0Jwvo2IJRp8chRRKKNlbcG3eokBf4rMmU+ni8UNm71H4rPRH9bCk9KWZk5E1JgfeSe5c0eps4EYml5uJPCWbyZqxSaeO03G6A0hJ8+2rRWG+5N0bjyCo6YTyhgnmYI7E/DQ4yGu7Veo7ros= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775644354; c=relaxed/simple; bh=35dZI7XO1PuiJnOPWLTJBYXPR5BzBRQMTO9NszVmMig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qATpZl7+1hZSc5cPDHVlPuRaF4xBfBhQ0JiHo+3yu4jeLC/bpsjDJu9llAjrI0k0UfzbJuAUfHGyU/o8LvF/EY7Hv1pWgvX1E7Zp+xFDvVGuw0GzqLbWxGe8riAGt1c9YJn3M67xT3qfLGbLtoGyWJTmL94t/TaGNKMNQqaDtM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=rxbWcZha; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="rxbWcZha" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C30BD3161; Wed, 8 Apr 2026 03:32:23 -0700 (PDT) Received: from [10.164.148.132] (unknown [10.164.148.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D3D353F632; Wed, 8 Apr 2026 03:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775644349; bh=35dZI7XO1PuiJnOPWLTJBYXPR5BzBRQMTO9NszVmMig=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rxbWcZha44mxHubats2n644JcLuCJ2t6+aYwy3oEEKRUt585T1ypA4Zhmn6pH8tOh NNizpDyFqVP89fY0uUhdFLY/E1hRXIFOiUJ0CWwbEZt/ipRNyeKL1dh1SllxAlwxnC HVDu6czp/sLowr29z8aNI93SI/T5IsMynfnKbAmQ= Message-ID: <02b0464a-13f6-4e0c-ad69-0f494bfacbf4@arm.com> Date: Wed, 8 Apr 2026 16:02:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/8] arm64/hugetlb: Extend batching of multiple CONT_PTE in a single PTE setup To: "Barry Song (Xiaomi)" , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, ryan.roberts@arm.com, ajd@linux.ibm.com, rppt@kernel.org, david@kernel.org, Xueyuan.chen21@gmail.com References: <20260408025115.27368-1-baohua@kernel.org> <20260408025115.27368-2-baohua@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20260408025115.27368-2-baohua@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/04/26 8:21 am, Barry Song (Xiaomi) wrote: > For sizes aligned to CONT_PTE_SIZE and smaller than PMD_SIZE, > we can batch CONT_PTE settings instead of handling them individually. > > Signed-off-by: Barry Song (Xiaomi) > --- > arch/arm64/mm/hugetlbpage.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index a42c05cf5640..bf31c11ebd3b 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -110,6 +110,12 @@ static inline int num_contig_ptes(unsigned long size, size_t *pgsize) > contig_ptes = CONT_PTES; > break; > default: > + if (size < CONT_PMD_SIZE && size > 0 && > + IS_ALIGNED(size, CONT_PTE_SIZE)) { Nit: Having the lower bound check before upper bound is natural to read, so this should be size > 0 && size < CONT_PMD_SIZE (i.e written the other way around). Also IS_ALIGNED needs to go below size. > + contig_ptes = size >> PAGE_SHIFT; > + *pgsize = PAGE_SIZE; > + break; > + } > WARN_ON(!__hugetlb_valid_size(size)); > } > > @@ -359,6 +365,10 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags) > case CONT_PTE_SIZE: > return pte_mkcont(entry); > default: > + if (pagesize < CONT_PMD_SIZE && pagesize > 0 && > + IS_ALIGNED(pagesize, CONT_PTE_SIZE)) > + return pte_mkcont(entry); > + > break; > } > pr_warn("%s: unrecognized huge page size 0x%lx\n",