From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935D2373C10 for ; Fri, 13 Mar 2026 08:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773389697; cv=none; b=XnwKsmPQQhiv2WqV8sJ4WyLzELhM311Y20r9R99+2G4S1jT7e70W/30vsxW6DcjM7qJkRNOwarHI//ZoyCzkZdX0KMhTVlC3xE0ThYJEoa5Kdvov2CHgsFVLaJZ0fyOyBV2J/ik6P77OV+4HEMvCCELCKAvvQan//EPpsKt/dIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773389697; c=relaxed/simple; bh=fDXzUzHNY1JtUUBDuVMzX0MjMZa2bBmDKFminzsEfD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MBmsvrFvnGgHLldH9HTRpmTgHGubDt8/8y3KRgFirPSWqY0Fj1/fH76/JWtKLltqNVJk4c+KQfl1XHbqQJzs3QJD3cTPuT1E1NHNnp3DAFz3zuGDzJIZEoruWnr1bWk3KHbaGPOA/AMb+AzuiY2l0BK1ijjvA+MbqE7VZxj1g5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Njdkpu3D; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VQb4LFWY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Njdkpu3D"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VQb4LFWY" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tmCx3844431 for ; Fri, 13 Mar 2026 08:14:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6ziuDQJxvUKyStLMOQ0E0BpVNIHaol6EdHTdMA0u17k=; b=Njdkpu3DOlV6ytdY gKe5u9LKTZudba7p5eInWpoClIcYNrKj4UllZbxJZQ68ZelKQ4ABw2t527Kvwllr hYjhWxMcCPdeqhxBT2ZYdmQEiMKh2XHLAUnODztTmubX5wxYanznTmqAXYApLPdI su5gUkGa2EGR8v9F/1NLIdrx3osdPBJ7t/UaS/PKMaGpw7i74qkUDq3o/UAUlgUl wCC+E7v4aw7LPPrDssWRXXJMT0GjMHT8mVCWkm8l+JNfxl1NRYZMXtPDhlQXVNNG aM2l2uSlnkhNvdRQMk64I0mTLr5gfU+Q0Gtf6gPCnhT14M4IiGZ7zzwjib2Uspey 2AqSzQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54w4tn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 08:14:54 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50923a9bec8so32619101cf.3 for ; Fri, 13 Mar 2026 01:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773389694; x=1773994494; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=6ziuDQJxvUKyStLMOQ0E0BpVNIHaol6EdHTdMA0u17k=; b=VQb4LFWYp1xyqD+usCDZYJeHLp50705NKAueh2e0jQUC8W82BO8UePobUh9N1T9gtW P17gri0TAa25phPc2Q56vkFBaNU/TsJzL6UU6S07MBdpOMJkz59b/xTTsqlrFtswiXxu Wo3gsmao7N98cAf/3xKqn8MRjRk3ndFBm2GeXOPeyXfHdZ3w+U7o/hp15E01Cpcn71wD 5KfG5sufUSclJh1/EzEsx0sKLKOUD6WpeqGR13kM0QLBnaU7Kg67YNthPjVbVFTr8wTh Ju6BFJ7dlUqj99OKqdPO5M4d17khEKPr5UNtnNtL+olopX5HJn5OA0SYdKZ4xLR3h6I6 qTsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773389694; x=1773994494; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6ziuDQJxvUKyStLMOQ0E0BpVNIHaol6EdHTdMA0u17k=; b=PcGytecovmYt9yomoz1pB24QSIffldcmqBHWpD63Te+KJPwUkFWycP0BTTQ2YMJmmw 9p9HgzKbjcbrV7NmAqld/Oe0bEeqElzApsve8fvRvNBaK9tDcIjyUlgnix63LM8mcYAR D9hHJU2GP9Kq2rTXqNM4I2JAFASkJ8IaSVUBCNa7ZdgOz0Qya7nfBxVnKDzrtBrpxt+P /N9SzGV9sETpzJ4z7Ben7HByiS4EwL71LaE1Zz/fyZtGQf2lnuKz808OSL0Mzg0NNqIw cse8HohKUw3/CSX1qaFgWN8ZnE80NxwI+3nOJN2mLq2uDL8CzOmlGvy0/Ks2rELlTD/B hW7A== X-Gm-Message-State: AOJu0Yz49FH+hBK+GYuBTxX/GKD2gRlImQpwr8r+q2D0GXEu9aW7DI0b e2XwHFKUV2ILqX/jSA0QHq0626YvXJs0T6OzJBJzmd8fUjh2QZMyvoNAKBwYN2qe+DEOHU+0jaL 1ouHSPltcoLSSFMaZwUStNK26fsYrdwjKAqZSFOs3oS+wvYSq42jtpUdg6eRrdBhPXig= X-Gm-Gg: ATEYQzx3flDgnVBpCRAVwr3JMTHt96r0GkQrnOnhHwPo0Zq9ybrxWuq9AsEyerYs/Tc mg/3d7k5nUC9RX3rk0VcYK3KDGFUXaRkz0RFxffTlMbaXo1Ut5oAPS14x/N8N7VxKL0OEyi52su 3mn++QFr9yHLfY68kq7SG6Mjc0eRKfqbk4Ee9NtWXUhG9HDIQr2vatM400UPvxyP9RDhrvlQ6AL 6dDowrMVeiEN1VWqjnUpKdX0047nu3F9ANIwWa6gpoPELWFqQur0lSJInyCgTU7VmvHDhHBDWwZ t4YArziOMdAKf2x/rIUmzO9RNhT3fOJsu/dknW4szlR84JpjB8247RF3ssl9p+n4B6RhxMnGqYX yngMX34CXmnAUQ3U6ozmeCQu2VJM89eZI5LZxE2n5jwe8mwW6 X-Received: by 2002:ac8:5dcf:0:b0:509:2e65:1418 with SMTP id d75a77b69052e-50957cb5474mr29159501cf.7.1773389693627; Fri, 13 Mar 2026 01:14:53 -0700 (PDT) X-Received: by 2002:ac8:5dcf:0:b0:509:2e65:1418 with SMTP id d75a77b69052e-50957cb5474mr29159211cf.7.1773389693117; Fri, 13 Mar 2026 01:14:53 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854e67ea40sm144430035e9.7.2026.03.13.01.14.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 01:14:52 -0700 (PDT) Message-ID: <02b1e588-1feb-484e-9f3c-f6c9f0b8e00c@oss.qualcomm.com> Date: Fri, 13 Mar 2026 09:14:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT] pci: imx: Properly support upstream Linux reset-gpios property To: Max Merchel , Tom Rini , u-boot@lists.denx.de Cc: linux-kernel@vger.kernel.org References: <20260312192605.131132-1-krzysztof.kozlowski@oss.qualcomm.com> <9e8aa4e7-72ab-4b1a-b324-4c78b13b9741@ew.tq-group.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <9e8aa4e7-72ab-4b1a-b324-4c78b13b9741@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: C_BKwQtrp3FE-eQKta53tm7bHQAkFyvu X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b3c77e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=OdcAIBAYDLDBbgzDFZEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: C_BKwQtrp3FE-eQKta53tm7bHQAkFyvu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA2MyBTYWx0ZWRfX8vVp+kqDyQTy k97ekXrYYvyg1/vHx5U2KReUcwJE0eSW9wZEzJ0nBadVi53okAJYz/RW+C/Umc4bbNL5wEDg0tt tb41EeFQqNQ8gcqdpr2YDKU1q13F8oZezzaTxs5g6qGOQ69TVpDEkHU1KoVQ4OXKic3v063PYkT mhAQhUK8/39a73g/sJXhyTY+CBQ2m4QzjBQSZiAzwxeZVf78YIiohaPvnjzwujEtSaWsqY0tfjW nLeV0SR1MI58t7ZQ/iveQd/28E/0lozF70UfrACo0CYo972WYDtkxZVFbl3ZUePMQAiGBTAmJkt EyNNEq7tfvSBQyduKu7XlAFECERB5Hh26i9Txx4oEQwvOehPcXDrdpNGCrABG7i1MgKeLumUEEw lTWhbxYe2puXXfHLyzqr1L9KM3f10yk5uWjWc3+D9EVaSLX5F4xtXQUGCLRfv0DQA2TYqqnrrfy 2PDvQ3Td7r5aNeg1XSQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130063 On 13/03/2026 09:12, Max Merchel wrote: > > On 3/12/26 20:26, Krzysztof Kozlowski wrote: >> The driver requests explicitly "reset-gpio" property, not the one with >> "gpios" suffix but upstream Linux kernel deprecated it in 2021. >> Existing upstream Linux kernel DTS is being changed to "reset-gpios" >> property, thus update the driver to read that one too. >> >> Note that driver is probably broken already, because it parsed GPIO in >> standard way respecting the flags and on top of that applied the >> "reset-gpio-active-high" flag, thus "reset-gpio ACTIVE_LOW" with the >> "reset-gpio-active-high" property would be double inverted. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> 1. https://lore.kernel.org/linux-devicetree/20260312-dts-snps-reset-gpios-v2-12-0d5040eb4a1e@oss.qualcomm.com/ >> 2. See Linux kernel commit 42694f9f6407 ("dt-bindings: PCI: add snps,dw-pcie.yaml") >> --- >> drivers/pci/pcie_imx.c | 22 +++++++++++++++++++--- >> 1 file changed, 19 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c >> index 11c4ccbfc555..8d853ecf2c22 100644 >> --- a/drivers/pci/pcie_imx.c >> +++ b/drivers/pci/pcie_imx.c >> @@ -728,15 +728,31 @@ static int imx_pcie_dm_write_config(struct udevice *dev, pci_dev_t bdf, >> static int imx_pcie_dm_probe(struct udevice *dev) >> { >> struct imx_pcie_priv *priv = dev_get_priv(dev); >> + int ret; >> >> #if CONFIG_IS_ENABLED(DM_REGULATOR) >> device_get_supply_regulator(dev, "vpcie-supply", &priv->vpcie); >> #endif >> >> /* if PERST# valid from dt then assert it */ >> - gpio_request_by_name(dev, "reset-gpio", 0, &priv->reset_gpio, >> - GPIOD_IS_OUT); >> - priv->reset_active_high = dev_read_bool(dev, "reset-gpio-active-high"); >> + ret = gpio_request_by_name(dev, "reset-gpio", 0, &priv->reset_gpio, >> + GPIOD_IS_OUT); >> + if (!ret) { >> + /* >> + * Legacy property, invert assert logic based on >> + * reset-gpio-active-high. This won't work if flags are not >> + * matching the reset-gpio-active-high. >> + */ >> + priv->reset_active_high = dev_read_bool(dev, "reset-gpio-active-high"); > > A warning should also be issued when using the deprecated "reset-gpio" > property. > >             dev_warn(dev, "reset-gpio property deprecated, use > reset-gpios\n"); > Why? What would end user seeing this in their serial console do? The deprecated property is not a mistake, it's just deprecated. Best regards, Krzysztof