From: Wojciech Kudla <wk.kernel@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Nadav Amit <namit@vmware.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Wojciech Kudla <wk.kernel@gmail.com>
Subject: [PATCH] smp: generic ipi_raise tracepoint
Date: Wed, 20 May 2020 14:17:21 +0100 [thread overview]
Message-ID: <02b57f31-fc0c-df35-57bf-e0a297a7e6c4@gmail.com> (raw)
Preliminary discussion: https://lkml.org/lkml/2020/5/13/1327
This patch avoids introducing arch-specific trace points by leveraging
existing definition for ipi_raise.
Issues to address in potential future work:
- make ipi reason available on generic smp code level (possible?)
- addition of ipi_entry/ipi_exit tracepoints in generic smp code
Signed-off-by: Wojciech Kudla <wk.kernel@gmail.com>
---
kernel/smp.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index 7dbcb402c2fc..df6982a1d3f2 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -23,6 +23,11 @@
#include "smpboot.h"
+#define CREATE_TRACE_POINTS
+#include <trace/events/ipi.h>
+
+static const char *ipi_reason_missing __tracepoint_string = "";
+
enum {
CSD_FLAG_LOCK = 0x01,
CSD_FLAG_SYNCHRONOUS = 0x02,
@@ -34,6 +39,7 @@ struct call_function_data {
cpumask_var_t cpumask_ipi;
};
+
static DEFINE_PER_CPU_ALIGNED(struct call_function_data, cfd_data);
static DEFINE_PER_CPU_SHARED_ALIGNED(struct llist_head, call_single_queue);
@@ -176,8 +182,12 @@ static int generic_exec_single(int cpu, call_single_data_t *csd,
* locking and barrier primitives. Generic code isn't really
* equipped to do the right thing...
*/
- if (llist_add(&csd->llist, &per_cpu(call_single_queue, cpu)))
+ if (llist_add(&csd->llist, &per_cpu(call_single_queue, cpu))) {
+ if (trace_ipi_raise_enabled())
+ trace_ipi_raise(cpumask_of(cpu), ipi_reason_missing);
+
arch_send_call_function_single_ipi(cpu);
+ }
return 0;
}
@@ -474,6 +484,8 @@ void smp_call_function_many(const struct cpumask *mask,
__cpumask_set_cpu(cpu, cfd->cpumask_ipi);
}
+ trace_ipi_raise(cfd->cpumask_ipi, ipi_reason_missing);
+
/* Send a message to all CPUs in the map */
arch_send_call_function_ipi_mask(cfd->cpumask_ipi);
--
2.17.1
next reply other threads:[~2020-05-20 13:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:17 Wojciech Kudla [this message]
2020-05-20 13:33 ` Peter Zijlstra
2020-05-20 13:42 ` Wojciech Kudla
2020-05-20 13:51 ` Peter Zijlstra
2020-05-21 10:45 ` kbuild test robot
2020-05-21 19:00 ` Nadav Amit
2020-05-21 20:11 ` Wojciech Kudla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02b57f31-fc0c-df35-57bf-e0a297a7e6c4@gmail.com \
--to=wk.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®