From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACE2C3815B for ; Mon, 20 Apr 2020 16:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 844382082E for ; Mon, 20 Apr 2020 16:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726377AbgDTQoc (ORCPT ); Mon, 20 Apr 2020 12:44:32 -0400 Received: from ale.deltatee.com ([207.54.116.67]:42970 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgDTQoc (ORCPT ); Mon, 20 Apr 2020 12:44:32 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.92) (envelope-from ) id 1jQZX1-0008Cn-Qh; Mon, 20 Apr 2020 10:44:29 -0600 To: Abhishek Sahu , Andrew Morton , Dan Williams Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org References: <20200420082231.4202-1-abhsahu@nvidia.com> From: Logan Gunthorpe Message-ID: <02c40a96-b9dd-14d8-57f4-426322b76bf2@deltatee.com> Date: Mon, 20 Apr 2020 10:44:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200420082231.4202-1-abhsahu@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, bp@alien8.de, mingo@redhat.com, tglx@linutronix.de, dan.j.williams@intel.com, akpm@linux-foundation.org, abhsahu@nvidia.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] x86/mm: fix compilation error for unknown type name pgprot_t X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-04-20 2:22 a.m., Abhishek Sahu wrote: > commit 30796e18c299 ("x86/mm: introduce __set_memory_prot()") > added the function __set_memory_prot() which uses pgprot_t in > function prototype. The currently included header files in > do not include type name > pgprot_t. The pgprot_t is defined in . > > Fixes: 30796e18c299 ("x86/mm: introduce __set_memory_prot()") > Signed-off-by: Abhishek Sahu I assume this is only hit with a specific driver or something that includes set_memory.h without including pgtable_types.h before hand. It certainly compiles fine for me and the kbuild robot has had lots of time to test it with random configs. Reviewed-by: Logan Gunthorpe Thanks, Logan