From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31EF3EFFB6 for ; Tue, 19 May 2026 09:31:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183117; cv=none; b=NgZkSCYZ7tUYoQ6mZUYKtosvH/IxQy8jrW5Pj30+GAzzcgTFq9sQgH499sWkHLiuLuEkXm0ncREVj2YdsvtVuDSkyhqClLz0pBa9m3sKrkHEfWwuPQZLMfLI3eHIZnbttC362QYHeeYVLHMULoRWlFSFan7CrfhHps1jYjTcV0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183117; c=relaxed/simple; bh=+pKiQCnTbbNrcTYQM3IjvPGSOtiEVKyJ06H28ahrAqM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Q12Y8GKZUPBaGq7/ZOmf3BPHhG84CaNKN3509cYrq3sljcVBTxk4FHJb79nP2+9vBLPO2Cem4Z4JCyS9mm40camy9ufYWv6eaKyzxvHlOwblacZw4O+KpDgvsGcwAdJcV09Fdti8JW5DNqWnybwwgsuf4ZIU5vhKIelTMsvfQYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GwbjIz8d; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k7oJS+JC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GwbjIz8d"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k7oJS+JC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779183115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hsG579UNRNkHYChdG7Vazcz8j5/rVsPW6WDElHcMIwQ=; b=GwbjIz8dBbh6gFEPTP+zFFfFfUn6FMRf/HwQ6rCcm1gdagNdU10jjjQzRoKBn7GCGUTrSP 7rBL8siIdGYKVq1dn52K/lKHxTxdNbc2oe3HzdZJ0pfhTcDPh6Qx+iQYAKvZp5yF4ZXLcx rkMCRL353gVp9tF2kzrUWdOu764D3X4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-63-kjirrfHyOgW3OtJ7qpyXWg-1; Tue, 19 May 2026 05:31:53 -0400 X-MC-Unique: kjirrfHyOgW3OtJ7qpyXWg-1 X-Mimecast-MFC-AGG-ID: kjirrfHyOgW3OtJ7qpyXWg_1779183112 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48fda34ed0aso12830425e9.1 for ; Tue, 19 May 2026 02:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779183112; x=1779787912; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=hsG579UNRNkHYChdG7Vazcz8j5/rVsPW6WDElHcMIwQ=; b=k7oJS+JCxvh9bVAChuTwXkfkBMu9HZekfGApTHPy770VRYwKVJQySufBglxUcT8Sci KhySyDwwdUz7HTOXRRRXeQeZfCxJpVHfPhDDN7LaAvppv1UhAINO+z0mJMME5JPXZb+T dXaZEtfl8zfENamB9dNL9bsn5Q8376zqMRahNkT9vtav48k03ocu1QvE1Bwfbp6ivBkJ rV6lfG2y2AFIkNefQlLjXFniMTVkGSnYPlVPSS7w4V1Y4YMWe1VfIQgDZfjwpjFFuJle xunf26fFXflc/faJ6pcDmuzK+To/CK7zh3cqo0WrUugkdbWezFHyb+7Eyyc3koJL64RP iedw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779183112; x=1779787912; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hsG579UNRNkHYChdG7Vazcz8j5/rVsPW6WDElHcMIwQ=; b=ow5dXYBEtxk6xDZECIQCe0wiQDhVZ3WdzCA9dZ3kqO5gqMQSD3UzZcrfEvHVBMduNb iKhelWkJszM466Sgfiay66cOiUZKI5+e9+xJtXqaMQG+5LI0Pbx5RCaJa6TBXim3D8o2 1OV0qFOUW7KyAlGmNuxDMb9833Y2xb34BIQ2KnLDVSmP0cevKP229TtarTmrZ4edW4H/ vdFrZccLmwlsx5hdOqDZF2hW+Ow4osRaRb5FfLF2JhHZEW4mR5RXYQdEVn4g1KKVa6PF okf0rowERHRfr5v7GryivEAZcFlB+mo35CqJ9b93eU8oCCfTSL/kv/NJGAA6AaoASele EvvA== X-Gm-Message-State: AOJu0Yyqr61ObgZ3+UINAHK6iALLRTK7GRncrtuwFcIU9OhziEugevbw 24iblPd5H6kdHxPWmpbxeFRbmp6gFA46BSIBOfpMD1iuU332i8c+jxfxcYSRPkN5u2ZilChuotE a5Nt8gHIkhP3lT/hbfQyKCJxuXs8nB/7psH9eSmYUX0LTJEKD6PQXOpYkJ4UL8GuVRQ== X-Gm-Gg: Acq92OE9/iON1NBUXlKg6jAFHCH+L7DaD1WILfnHDF+tYdsRwxNhDyo8a5lWtV2R0cq ZV6lIYlnEi+k4fH/61bRUFZSOo1FywTiyPNKftVAaGCOXZ4yKVFnrA/KcvNAjs22DRfr3b07/iU BNCnPPSGM8lEKQRwlBLCykdS4V0MSI+awJJ3SflUKOFjRDUXuQFr+NNkTgdcp6ahyrboB1gk4Oz h+MuZduucY3OVDije7Bs9jZVOhC8BeTgBo/2IwpQMOu6NNlWHZlXBmVanp3VP5wiDkcHzq20Y+5 7mCzOj0sC6Vya+/G25noq55tliocAOorfuVAFIn2nlA++ZTkNmxeoOi9gy1WNG9otkW/5+aRLdw Oa89d6PdQTZhXpcRFKelPdYlkOCULJKbd22jWBRP1y106uznjH1XXvtsq5eSXc9fI3qhiRcd1nb VtsGz5MG3HCewVMN8= X-Received: by 2002:a05:600c:8597:b0:48f:d5d7:df89 with SMTP id 5b1f17b1804b1-48fe630a2b6mr203499195e9.25.1779183112240; Tue, 19 May 2026 02:31:52 -0700 (PDT) X-Received: by 2002:a05:600c:8597:b0:48f:d5d7:df89 with SMTP id 5b1f17b1804b1-48fe630a2b6mr203498845e9.25.1779183111781; Tue, 19 May 2026 02:31:51 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fea52a0bfsm156722615e9.0.2026.05.19.02.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 02:31:51 -0700 (PDT) Message-ID: <02c522f2a09183c9e1a6ff5b0110d0d5cc5e35bd.camel@redhat.com> Subject: Re: [PATCH 6/9] rv: Ensure synchronous cleanup for HA monitors From: Gabriele Monaco To: Wen Yang Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , linux-trace-kernel@vger.kernel.org Date: Tue, 19 May 2026 11:31:49 +0200 In-Reply-To: <88a6fc5c08d18e3c1f6d29dc106db80fa688bf87.camel@redhat.com> References: <20260512140250.262190-1-gmonaco@redhat.com> <20260512140250.262190-7-gmonaco@redhat.com> <88a6fc5c08d18e3c1f6d29dc106db80fa688bf87.camel@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-05-18 at 13:54 +0200, Gabriele Monaco wrote: > Something like: >=20 > void __ha_monitor_timer_callback() { > guard(rcu)(); //this is only for waiters, let them wait more >=20 > if (unlikely(!da_monitor_handling_event(&ha_mon->da_mon))) > return; > smp_rmb(); > curr_state =3D READ_ONCE(ha_mon->da_mon.curr_state); > ... > } >=20 > void da_monitor_reset() { > da_monitor_reset_hook(da_mon); > WRITE_ONCE(da_mon->monitoring, 0); > smp_wmb(); > WRITE_ONCE(da_mon->curr_state, model_get_initial_state()); > } That's obviously not going to work unless I read curr_state earlier (and us= e the acquire/release helpers while at it): void __ha_monitor_timer_callback() { guard(rcu)(); //this is only for waiters, let them wait more curr_state =3D smp_load_acquire(&ha_mon->da_mon.curr_state); if (unlikely(!da_monitor_handling_event(&ha_mon->da_mon))) return; ... } void da_monitor_reset() { da_monitor_reset_hook(da_mon); WRITE_ONCE(da_mon->monitoring, 0); smp_store_release(&da_mon->curr_state, model_get_initial_state()); }