From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520AbdEDJuC (ORCPT ); Thu, 4 May 2017 05:50:02 -0400 Received: from foss.arm.com ([217.140.101.70]:37254 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbdEDJty (ORCPT ); Thu, 4 May 2017 05:49:54 -0400 Subject: Re: [PATCH v2 1/2] sched/fair: Fix how load gets propagated from cfs_rq to its sched_entity To: Peter Zijlstra , Tejun Heo References: <20170424201344.GA14169@wtj.duckdns.org> <20170424201415.GB14169@wtj.duckdns.org> <20170424213324.GA23619@wtj.duckdns.org> <20170503180028.ejf73et3pc4meqji@hirez.programming.kicks-ass.net> <20170503214546.GA7451@htj.duckdns.org> <20170504055129.c7f7whdqpcqyvnrz@hirez.programming.kicks-ass.net> <20170504062109.d5o2dz6t4lqnkp5n@hirez.programming.kicks-ass.net> Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds , Vincent Guittot , Mike Galbraith , Paul Turner , Chris Mason , kernel-team@fb.com From: Dietmar Eggemann Message-ID: <02c93bb0-ad3c-9a01-0351-e4ee6e56bf1b@arm.com> Date: Thu, 4 May 2017 10:49:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170504062109.d5o2dz6t4lqnkp5n@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/17 07:21, Peter Zijlstra wrote: > On Thu, May 04, 2017 at 07:51:29AM +0200, Peter Zijlstra wrote: > >> Urgh, and my numbers were so pretty :/ > > Just to clarify on how to run schbench, I limited to a single socket (as > that is what you have) and set -t to the number of cores in the socket > (not the number of threads). > > Furthermore, my machine is _idle_, if I don't do anything, it doesn't do > _anything_. > I can't recreate this problem running 'numactl -N 0 ./schbench -m 2 -t 10 -s 10000 -c 15000 -r 30' on my E5-2690 v2 (IVB-EP, 2 sockets, 10 cores / socket, 2 threads / core) I tried tip/sched/core comparing running in 'cpu:/' and 'cpu:/foo' and using your patch on top with all the combinations of {NO_}FUDGE, {NO_}FUDGE2 with prop_type=shares_avg or prop_type_runnable. Where you able to see the issue on tip/sched/core w/o your patch on your machine? The workload of n 60% periodic tasks on n logical cpus always creates a very stable task distribution for me.