From: "Daniel Díaz" <daniel.diaz@linaro.org>
To: Anders Roxell <anders.roxell@linaro.org>, shuah@kernel.org
Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc
Date: Wed, 21 Feb 2018 15:38:45 -0600 [thread overview]
Message-ID: <02cb5e7d-5119-8501-01b7-9ea0f4b95450@linaro.org> (raw)
In-Reply-To: <20180221165116.9754-1-anders.roxell@linaro.org>
On 02/21/2018 10:51 AM, Anders Roxell wrote:
> Both glibc and the kernel have in6_* macros definitions. Build fails
> because it picks up wrong in6_* macro from the kernel header and not the
> header from glibc.
>
> Fixes build error below:
> clang -I. -I./include/uapi -I../../../include/uapi
> -Wno-compare-distinct-pointer-types \
> -O2 -target bpf -emit-llvm -c test_tcpbpf_kern.c -o - | \
> llc -march=bpf -mcpu=generic -filetype=obj
> -o .../tools/testing/selftests/bpf/test_tcpbpf_kern.o
> In file included from test_tcpbpf_kern.c:12:
> .../netinet/in.h:101:5: error: expected identifier
> IPPROTO_HOPOPTS = 0, /* IPv6 Hop-by-Hop options. */
> ^
> .../linux/in6.h:131:26: note: expanded from macro 'IPPROTO_HOPOPTS'
> ^
> In file included from test_tcpbpf_kern.c:12:
> /usr/include/netinet/in.h:103:5: error: expected identifier
> IPPROTO_ROUTING = 43, /* IPv6 routing header. */
> ^
> .../linux/in6.h:132:26: note: expanded from macro 'IPPROTO_ROUTING'
> ^
> In file included from test_tcpbpf_kern.c:12:
> .../netinet/in.h:105:5: error: expected identifier
> IPPROTO_FRAGMENT = 44, /* IPv6 fragmentation header. */
> ^
>
> Since both glibc and the kernel have in6_* macros definitions, use the
> one from glibc. Kernel headers will check for previous libc definitions
> by including include/linux/libc-compat.h.
>
> Reported-by: Daniel Díaz <daniel.diaz@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
FWIW, this was
Tested-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
> tools/testing/selftests/bpf/test_tcpbpf_kern.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_tcpbpf_kern.c b/tools/testing/selftests/bpf/test_tcpbpf_kern.c
> index 57119ad57a3f..3e645ee41ed5 100644
> --- a/tools/testing/selftests/bpf/test_tcpbpf_kern.c
> +++ b/tools/testing/selftests/bpf/test_tcpbpf_kern.c
> @@ -5,7 +5,6 @@
> #include <linux/if_ether.h>
> #include <linux/if_packet.h>
> #include <linux/ip.h>
> -#include <linux/in6.h>
> #include <linux/types.h>
> #include <linux/socket.h>
> #include <linux/tcp.h>
next prev parent reply other threads:[~2018-02-21 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 16:51 Anders Roxell
2018-02-21 21:38 ` Daniel Díaz [this message]
2018-02-22 0:23 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cb5e7d-5119-8501-01b7-9ea0f4b95450@linaro.org \
--to=daniel.diaz@linaro.org \
--cc=anders.roxell@linaro.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®