mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Zhang Rui <rui.zhang@intel.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	peter.ganzhorn@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment
Date: Fri, 7 Apr 2023 09:01:03 -0700	[thread overview]
Message-ID: <02cbffad-7f61-491e-a67b-8cc22a65881a@roeck-us.net> (raw)
In-Reply-To: <20230330103346.6044-2-rui.zhang@intel.com>

On Thu, Mar 30, 2023 at 06:33:46PM +0800, Zhang Rui wrote:
> The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
> has been changed for several times.
> 
> Now, the raw value from MSR is used without refinement. Thus remove the
> obsolete comment.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/coretemp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index fe3d4d0dcbed..eba94f68585a 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
>  			dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
>  	} else {
>  		val = (eax >> 16) & 0xff;
> -		/*
> -		 * If the TjMax is not plausible, an assumption
> -		 * will be used
> -		 */
>  		if (val)
>  			return val * 1000;
>  	}

  reply	other threads:[~2023-04-07 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30 10:33 [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Zhang Rui
2023-03-30 10:33 ` [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment Zhang Rui
2023-04-07 16:01   ` Guenter Roeck [this message]
2023-04-07 16:00 ` [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02cbffad-7f61-491e-a67b-8cc22a65881a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.ganzhorn@gmail.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®