From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: apw@canonical.com, joe@perches.com
Subject: checkpatch error
Date: Tue, 8 Oct 2019 12:02:47 +0800 [thread overview]
Message-ID: <02cc0e89-8b48-14f6-aabe-ec1201df59aa@oracle.com> (raw)
Hi,
When I run checkpatch.pl with a patch doing reverting operation, it
reports a false positive error, Should I ignore the error or it's a bug?
0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch
---------------------------------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 090d54bcbc54 ("Revert
"x86/paravirt: Set up the v'
#14:
The similar change for XEN is in commit 090d54bcbc54 ("Revert
total: 1 errors, 0 warnings, 31 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or
--fix-inplace.
# cat 0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch
From 5d90690ba0476cab223f5e1d13955858b9c91623 Mon Sep 17 00:00:00 2001
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Date: Mon, 7 Oct 2019 09:20:58 +0800
Subject: [PATCH v5 1/5] Revert "KVM: X86: Fix setup the virt_spin_lock_key
before static key get initialized"
This reverts commit 34226b6b70980a8f81fff3c09a2c889f77edeeff.
Commit 8990cac6e5ea ("x86/jump_label: Initialize static branching
early") adds jump_label_init() call in setup_arch() to make static
keys initialized early, so we could use the original simpler code
again.
The similar change for XEN is in commit 090d54bcbc54 ("Revert
"x86/paravirt: Set up the virt_spin_lock_key after static keys get
initialized"")
...
Thanks
Zhenzhong
next reply other threads:[~2019-10-08 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 4:02 Zhenzhong Duan [this message]
2019-10-08 7:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cc0e89-8b48-14f6-aabe-ec1201df59aa@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®