From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 189E0286426 for ; Tue, 22 Jul 2025 21:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753220472; cv=none; b=PrwgaDYrAVgP23c2C3usAyEtQ/w2U0jK9DURhBOD6pBLlbVfXXIAFKjSdeViMVEfLaQ6zbbG9F0DL3L5oYMsJG7WWsFkGM4zaPbR4kzv3kmieQ20eJdjwqw8MiyN7JETU9ss/MOJUiwGSRX2PTxRJvaMAT/hmyzSu3/JBk3nswg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753220472; c=relaxed/simple; bh=1++6CwyVXIhS0UVn0IwIwObfps05A2Vqkiy+jJBxzzA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ADgZgmaq1S3WEF7HYFJbve6mOciyB4i6W4SJERTw/LdK6iAJ6ew4xrw5BKNdEps8pDs33VfvDso4vzSiScH+oRnfZP1Wmn1/hE81S9MkbWcH3EY/DPSqBqg5c6AAnDy2c4JqbEC9/9/tGuXsly8ZsXv+TvbODvMIVsXxYHd1mpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EFU09Jt6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EFU09Jt6" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56MKTPqo030717 for ; Tue, 22 Jul 2025 21:41:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jjqeRMS/46ph8PMRqSc+j1jHH5fh1ltcyKMQO/fuhWo=; b=EFU09Jt6AD+YRXLL pLgqiVq0wEeKhRgF5abY5Z0yiZHrPlHbor7i2DdETV0Z3EXMDY/qc51RT/cEOjvx MktNxllr1DW/6HMysgzyNTIYJ+k9kOCUiVeka24JsXhrX/tTvUUlygbRKQhAsM97 0eW6nYR8woBJK9Kewf2BSSyLHigkdwDiAoLDe5TzznK9szmnksJrskPoFNJXmMnk yZoNDUyzXJXDHrskBoAmo3Kk07ePvld60vV92H0XUmXRIb8yiB0CWNU75FM0C5EW 4ajn/hULaAumpB0Tp2AgpsA+NnvRAr/cx1DeQAXfBlts45kaJlOZLzkxZlrUld09 69/Ncg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48048v98g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 22 Jul 2025 21:41:10 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-75e28bcec3bso2836163b3a.1 for ; Tue, 22 Jul 2025 14:41:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753220469; x=1753825269; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jjqeRMS/46ph8PMRqSc+j1jHH5fh1ltcyKMQO/fuhWo=; b=L1ZGlovrtYtYIKhCFrtXJKvcyCjVWOwMxV9lc1ivBDLkGZT64x/yaTj356ByIVx4Pf f5AVHlPx0TgW8jar88J5ifsu7CxjhOUw9B7x0J1W4I9OOeZziOD9U/BuGdeqqpK22C7r bX16jZSdMukwJpsCOj+V0XsMwR7vyr99EJIF+dguKL9BMUNHrVkVpC/xGA/PlY4ruTPW vh7pZK3fAldTS5QkIeWc/4IrbApvFdz5avqpVq1YRr38ZgpgtX9mbJYoM5x5/CpSk2CD XQZPzhuOvF8IWK/1ruQSeqZY48VkYqe7ll+tShDpUF8GlmlpBxHkEK7i36Ugi48iAngF W4Xw== X-Forwarded-Encrypted: i=1; AJvYcCXww9M7LGEnUQgozeULP44FQ0W2ajEF1BNQdQ2uvaz5VkGdsw5z37Rrjjfoc4OXTGS4ScJw6KWF5y67dYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx76Xp4WDWJ6/9hBQEWBLAgP5jdjerf2Wur5aIJ3ORDsnzEY6n iOlgIjUOVj0Oma/lEUrHiCYavb1Oxd2cMaKs1kkXRJxzZJtxdsXNEKI8B61DtBt07mTrPDfru9S +Kuc/0BatkgBLFgnDt5lwAyPSyZuAlPrCwzNnEuxckzAlhlUIGhl47sUqZ6bNxSaI39g= X-Gm-Gg: ASbGnctE5DegQHrMAN8TmD2YMNSHNuTXJCNjed2XCU+ODLVp0YG5MMCjnRp3dqUdcuh 0zQ3/nUYqTAodlAiTq3EovgIK/CxVFhShtqcFHaOZelufpud85ZAlVyXBCgqPCq7rZfs+JPU1Sv lnnNXk3AOHPfVT+xwVYfJzMlui4xg3GA/maeOULEhqz+0xsWJat/L0qXc6pvu++gD2AR5SXd/rS yAkEySYPVqZ4J9emR/+d8i6vUmVZXIB0uoYUvy7mYWHwE+4dLTxk33UGTmAb9CxE4JU+uwOaev9 BqdaZy81GVW+GkPpNsyWVSRHjEgiqxHolu4puP2Djx2WYnY1V0DY9/pDN0YEWXOc X-Received: by 2002:a05:6a20:9148:b0:217:ff4b:cc57 with SMTP id adf61e73a8af0-23d4915fb8amr590774637.39.1753220469364; Tue, 22 Jul 2025 14:41:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAegiXBmz6me1rwnZXHQKFdO1xAzXIAxFFtINhqI1FUmRxyNoREYp9vqjr22X1YmcsF9Ffmg== X-Received: by 2002:a05:6a20:9148:b0:217:ff4b:cc57 with SMTP id adf61e73a8af0-23d4915fb8amr590746637.39.1753220468954; Tue, 22 Jul 2025 14:41:08 -0700 (PDT) Received: from [192.168.1.4] ([106.222.235.133]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-75ef7510655sm2143552b3a.55.2025.07.22.14.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jul 2025 14:41:08 -0700 (PDT) Message-ID: <02d1fa2a-0faf-44db-a683-53c5a51e09f1@oss.qualcomm.com> Date: Wed, 23 Jul 2025 03:11:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/17] drm/msm/a6xx: Enable IFPC on Adreno X1-85 To: Konrad Dybcio , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250720-ifpc-support-v1-0-9347aa5bcbd6@oss.qualcomm.com> <20250720-ifpc-support-v1-16-9347aa5bcbd6@oss.qualcomm.com> <38100984-df2c-4a15-a192-7f38b8671145@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <38100984-df2c-4a15-a192-7f38b8671145@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: b2rbW81oqCmwje1MxovxSDnV8avFJp5s X-Authority-Analysis: v=2.4 cv=SYL3duRu c=1 sm=1 tr=0 ts=68800576 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=4dphQItTPUswyQvINXrzgA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=wgrHQ5V9N6DtgpC36WEA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIyMDE4NyBTYWx0ZWRfX11H6Hror5ps6 btx7K+8axnoMbQ+IwuQcbQba3pzrFN2RL7jaW2ObaM0d/ss+b7KfGSZ1I3tU21kGqxJYMN2N5hC Y22EC58cpMPadEpajr6GAcy6KgVTvE43omv+H+2QnKtO4YCYMTs67GdJdqZZvDX3Q4vAtOYP7Sr Y2uKaS8axBQceXv2LLevd3JcBaVkdLzpAyzPM0m3gasUYxJp3jRo7Qp6UC6MXkvq6ab54z7ommJ 317LNMs/KE82yleIxUhZgWbs7C/+sOtRzaWI6DXbhJZqISaieqkjdqkX+nwW908rh6WKh9qWNuJ 8Fu8Dw+P07oN1awIzACw4ct5Ud+audDXY3iihgsQJnx1W/B++GCJg5ZuF4L3i7kzrwizz/AlX5q OJioA8/GSGpxlVOLvjwWJ1Li1ToHgvqt2rFcs+wtZP649Py+HyKMu4u6cR/VMUgey3RY8CkJ X-Proofpoint-ORIG-GUID: b2rbW81oqCmwje1MxovxSDnV8avFJp5s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-22_03,2025-07-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=596 lowpriorityscore=0 phishscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507220187 On 7/22/2025 8:25 PM, Konrad Dybcio wrote: > On 7/20/25 2:16 PM, Akhil P Oommen wrote: >> Add the IFPC restore register list and enable IFPC support on Adreno >> X1-85 gpu. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 67 ++++++++++++++++++++++++++++++- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 +++++-- >> drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + >> 3 files changed, 78 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> index 70f7ad806c34076352d84f32d62c2833422b6e5e..07fcabed472c3b9ca47faf1a8b3f7cf580801981 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >> @@ -1343,6 +1343,69 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = { >> >> DECLARE_ADRENO_REGLIST_LIST(a7xx_pwrup_reglist); >> >> +/* Applicable for X185, A750 */ >> +static const u32 a750_ifpc_reglist_regs[] = { >> + REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_0, >> + REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_1, >> + REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_2, >> + REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_3, >> + REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_4, >> + REG_A6XX_TPL1_NC_MODE_CNTL, >> + REG_A6XX_SP_NC_MODE_CNTL, >> + REG_A6XX_CP_DBG_ECO_CNTL, >> + REG_A6XX_CP_PROTECT_CNTL, >> + REG_A6XX_CP_PROTECT(0), >> + REG_A6XX_CP_PROTECT(1), > > Is it fair to assume that we'd like to saverestore all CP_PROT > registers on all SKUs, always? We can save some space in .rodata > this way.. Yeah. Makes sense, but lets do that when we duplicate it in future. -Akhil > > Konrad