mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Alexandre Courbot <acourbot@nvidia.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Gary Guo <gary@garyguo.net>,
	nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Date: Thu, 12 Mar 2026 11:54:11 -0700	[thread overview]
Message-ID: <02daf179-d816-4e54-a91a-5f8eeb2a9576@nvidia.com> (raw)
In-Reply-To: <abMJsUpvcUrITCVi@eric-acer>

On 3/12/26 11:45 AM, Cheng-Yang Chou wrote:
...
>>>   kernel::module_auxiliary_driver! {
>>>       type: NovaDriver,
>>> -    name: "Nova",
>>> +    name: "nova-drm",
>>
>> Well, but now it is out of sync with the file name: nova.rs.
>>
>> You should change both, or neither, I'm thinking.
> 
> I think renaming the file to nova_drm.rs would better reflect the
> driver's identity now that the module name is nova-drm, making it easier
> for readers to associate the source file with the driver.
> 
> Would that work for you?
> 

I'm OK with the name change.

thanks,
-- 
John Hubbard


  reply	other threads:[~2026-03-12 18:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  6:24 Cheng-Yang Chou
2026-03-10 20:41 ` Timur Tabi
2026-03-11  1:34 ` John Hubbard
2026-03-12 18:45   ` Cheng-Yang Chou
2026-03-12 18:54     ` John Hubbard [this message]
2026-03-12 19:16     ` Danilo Krummrich
2026-03-12 19:21       ` John Hubbard
2026-03-12 19:48         ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02daf179-d816-4e54-a91a-5f8eeb2a9576@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®