From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, devel@driverdev.osuosl.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen A McCamant <smccaman@umn.edu>,
Colin Ian King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: fix multiple memory leaks on error path
Date: Fri, 27 Sep 2019 18:09:09 +0200 [thread overview]
Message-ID: <02e4032a-d5f4-abfc-1d71-6a8d50554e40@web.de> (raw)
In-Reply-To: <20190920025137.29407-1-navid.emamdoost@gmail.com>
> In rtl8192_tx on error handling path allocated urbs and also skb should
> be released.
Can this change description be improved?
How do you think about to add the tag “Fixes” here?
> @@ -1588,7 +1590,12 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> RT_TRACE(COMP_ERR, "Error TX URB %d, error %d",
> atomic_read(&priv->tx_pending[tcb_desc->queue_index]),
> status);
> - return -1;
> +
> +error:
> + dev_kfree_skb_any(skb);
…
Would an other label be more appropriate according to the Linux coding style?
Regards,
Markus
next prev parent reply other threads:[~2019-09-27 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 2:51 Navid Emamdoost
2019-09-20 6:05 ` Greg Kroah-Hartman
2019-09-27 16:09 ` Markus Elfring [this message]
2019-09-30 21:35 ` Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02e4032a-d5f4-abfc-1d71-6a8d50554e40@web.de \
--to=markus.elfring@web.de \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=emamd001@umn.edu \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome