From: Hans de Goede <hdegoede@redhat.com>
To: Brenton Simpson <appsforartists@google.com>
Cc: Allen Ballway <ballway@chromium.org>,
Patrick Thompson <ptf@google.com>,
Jared Baldridge <jrb@expunge.us>,
Emil Velikov <emil.l.velikov@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go
Date: Wed, 15 Nov 2023 17:32:20 +0100 [thread overview]
Message-ID: <02ea9279-7bdc-43ca-bd7d-898dee14884e@redhat.com> (raw)
In-Reply-To: <CAAL3-=_p4waxpf9a6B0Yvno0dnakZ6f81-Kfjxwbw4jA_CrcSw@mail.gmail.com>
Hi Brenton,
On 11/15/23 16:52, Brenton Simpson wrote:
> Yes, thanks!
>
> That's the email attached to my public git work, so it should be the
> one here as well.
Ok, I've pushed this to drm-misc-fixes now, thank you for the patch.
> Sorry for the hassle. Very new to sending PRs over email, and still
> working through the kinks.
Your initial submission was almost there. Just the weird thing
with the + in the From: email-address. What also threw me off
is that the From was: <brentons+appsforartists@google.com>
Normally the '+' + the part after it gets thrown away to get
the canonical email address, so that would make your canonical
email: <brentons@google.com> where I now know it should be:
<appsforartists@google.com> .
So next time you use a + address please do something like:
<appsforartists+brentons@google.com>
I also guess you never got any of the replies addressed to
<brentons+appsforartists@google.com> since the mail server
presumably has tried to deliver those to <brentons@google.com>,
but because your normal email was in the Cc things still
worked out.
Either way for future patches note that using "git send-email"
is the advised way to submit kernel patches.
Regards,
Hans
next prev parent reply other threads:[~2023-11-15 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 23:38 Brenton Simpson
2023-11-15 12:33 ` Hans de Goede
[not found] ` <CAAL3-=9YYQBV-T-KhHdYrtGHH1RC29uzTuQ98roAY9GwrNrwmg@mail.gmail.com>
2023-11-15 15:48 ` Brenton Simpson
2023-11-15 15:49 ` Brenton Simpson
2023-11-15 15:50 ` Hans de Goede
2023-11-15 15:52 ` Brenton Simpson
2023-11-15 16:32 ` Hans de Goede [this message]
2023-11-16 17:54 ` Brenton Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ea9279-7bdc-43ca-bd7d-898dee14884e@redhat.com \
--to=hdegoede@redhat.com \
--cc=appsforartists@google.com \
--cc=ballway@chromium.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jrb@expunge.us \
--cc=linux-kernel@vger.kernel.org \
--cc=ptf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®