From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428460AbdDYIOJ (ORCPT ); Tue, 25 Apr 2017 04:14:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60664 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S980464AbdDYIN4 (ORCPT ); Tue, 25 Apr 2017 04:13:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 950D96137F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH -next] phy: qcom-qmp: fix invalid use of sizeof in qcom_qmp_phy_vreg_init() To: Wei Yongjun , Kishon Vijay Abraham I References: <20170425065703.11211-1-weiyj.lk@gmail.com> Cc: Wei Yongjun , linux-kernel@vger.kernel.org From: Vivek Gautam Message-ID: <02f41a36-d12c-d61a-ff51-f89e609704b5@codeaurora.org> Date: Tue, 25 Apr 2017 13:43:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20170425065703.11211-1-weiyj.lk@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/25/2017 12:27 PM, Wei Yongjun wrote: > From: Wei Yongjun > > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. > > Signed-off-by: Wei Yongjun > --- Apparently Kbuild had caught this and sent a similar patch. But I missed that. Thank you for the patch. I have requested Kishon to pull in the patch from Kbuild along with your patch [1] fixing the return value for of_iomap. [1] https://lkml.org/lkml/2017/4/24/1080 Best Regards Vivek > drivers/phy/phy-qcom-qmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-qcom-qmp.c b/drivers/phy/phy-qcom-qmp.c > index 727e23b..7d6085f 100644 > --- a/drivers/phy/phy-qcom-qmp.c > +++ b/drivers/phy/phy-qcom-qmp.c > @@ -844,7 +844,7 @@ static int qcom_qmp_phy_vreg_init(struct device *dev) > int num = qmp->cfg->num_vregs; > int i; > > - qmp->vregs = devm_kcalloc(dev, num, sizeof(qmp->vregs), GFP_KERNEL); > + qmp->vregs = devm_kcalloc(dev, num, sizeof(*qmp->vregs), GFP_KERNEL); > if (!qmp->vregs) > return -ENOMEM; > -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project