From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Claudiu <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<biju.das.jz@bp.renesas.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH net-next v4 5/6] net: ravb: Do not apply features to hardware if the interface is down
Date: Wed, 14 Feb 2024 20:07:20 +0300 [thread overview]
Message-ID: <02f45526-0d56-469c-db3d-de1ef8785685@omp.ru> (raw)
In-Reply-To: <20240214135800.2674435-6-claudiu.beznea.uj@bp.renesas.com>
On 2/14/24 4:57 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Do not apply features to hardware if the interface is down. In case runtime
> PM is enabled, and while the interface is down, the IP will be in reset
> mode (as for some platforms disabling the clocks will switch the IP to
> reset mode, which will lead to losing register contents) and applying
> settings in reset mode is not an option. Instead, cache the features and
> apply them in ravb_open() through ravb_emac_init().
>
> To avoid accessing the hardware while the interface is down
> pm_runtime_active() check was introduced. Along with it the device runtime
> PM usage counter has been incremented to avoid disabling the device clocks
> while the check is in progress (if any).
>
> Commit prepares for the addition of runtime PM.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
next prev parent reply other threads:[~2024-02-14 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 13:57 [PATCH net-next v4 0/6] net: ravb: Add runtime PM support (part 2) Claudiu
2024-02-14 13:57 ` [PATCH net-next v4 1/6] net: ravb: Get rid of the temporary variable irq Claudiu
2024-02-14 13:57 ` [PATCH net-next v4 2/6] net: ravb: Keep the reverse order of operations in ravb_close() Claudiu
2024-02-14 13:57 ` [PATCH net-next v4 3/6] net: ravb: Return cached statistics if the interface is down Claudiu
2024-02-14 13:57 ` [PATCH net-next v4 4/6] net: ravb: Move the update of ndev->features to ravb_set_features() Claudiu
2024-02-14 16:55 ` Sergey Shtylyov
2024-02-14 13:57 ` [PATCH net-next v4 5/6] net: ravb: Do not apply features to hardware if the interface is down Claudiu
2024-02-14 17:07 ` Sergey Shtylyov [this message]
2024-02-14 13:58 ` [PATCH net-next v4 6/6] net: ravb: Add runtime PM support Claudiu
2024-02-16 8:40 ` [PATCH net-next v4 0/6] net: ravb: Add runtime PM support (part 2) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02f45526-0d56-469c-db3d-de1ef8785685@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®