From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932487AbbJVBsQ (ORCPT ); Wed, 21 Oct 2015 21:48:16 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:41239 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523AbbJVBsO (ORCPT ); Wed, 21 Oct 2015 21:48:14 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-df-5628405c1cbd From: Chao Yu To: "'Valdis Kletnieks'" , "'Jaegeuk Kim'" , "'Changman Lee'" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <37662.1445450735@turing-police.cc.vt.edu> In-reply-to: <37662.1445450735@turing-police.cc.vt.edu> Subject: RE: next-20151021 - compile error in fs/f2fs/checkpoint.c Date: Thu, 22 Oct 2015 09:47:22 +0800 Message-id: <02fe01d10c6b$b5cab610$21602230$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQK9dgDEYWXP96fc+1ZmVqT2izIVapyd5eWw Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t9jQd1YB40wg98dTBbX9jUyWTxZP4vZ 4tIid4vLu+awWVx6/4HFgdVj06pONo/dCz4zefRtWcXo8XmTnMeh7W/YAlijuGxSUnMyy1KL 9O0SuDKaN05lKpjFV3F+xUe2BsbL3F2MnBwSAiYSi99NZYewxSQu3FvP1sXIxSEkMItR4sXL 5YwQzitGiQPvulhBqtgEVCSWd/xnArFFBOokfu6eDNbNLOAh0djxHaxGSMBMYmLXXLA4p4C5 xOS2w2C2sICzxJV1P8BsFgFViQ9dO5lBbF4BS4m+qa3sELagxI/J91ggZmpJrN95nAnClpfY vOYtM8SlChI7zr5mhLjBSKJ5ympGiBpxiY1HbrFMYBSahWTULCSjZiEZNQtJywJGllWMEqkF yQXFSem5hnmp5XrFibnFpXnpesn5uZsYwfHxTGoH48Fd7ocYBTgYlXh4L/xRDxNiTSwrrsw9 xCjBwawkwvvPUiNMiDclsbIqtSg/vqg0J7X4EKM0B4uSOO+NQwxhQgLpiSWp2ampBalFMFkm Dk6pBsaLsxxjin32/GV+5dyYdkTo8rEUIe+PzwtO2XNEb96hKGhUYHIk84d6QKT6Ya6/H4zt mu+YXVY3ejDV8kT+Y5+I4C8iN48IskldnGy8Z4bJjw/bO/bkr+IU53j5rGefYuqTfs69szu5 nn6+HlFqwF0iYtK14vM13aeng55l3I6u39iZdSa6WkmJpTgj0VCLuag4EQCOHVxSiwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, > -----Original Message----- > From: Valdis Kletnieks [mailto:Valdis.Kletnieks@vt.edu] > Sent: Thursday, October 22, 2015 2:06 AM > To: Chao Yu; Jaegeuk Kim; Changman Lee > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: next-20151021 - compile error in fs/f2fs/checkpoint.c > > Building next-20151021 dies with this error: > > CC [M] fs/f2fs/checkpoint.o > fs/f2fs/checkpoint.c: In function 'get_valid_checkpoint': > fs/f2fs/checkpoint.c:707:3: error: too few arguments to function 'ra_meta_pages' > ra_meta_pages(sbi, cp_blk_no + 1, cp_blks - 1, META_CP); Above invoking is added in commit ("f2fs: readahead cp payload pages when mount") at ~9/12/2015, but sadly it's complete wrong due to my fault, so it is removed in our dev-test branch by Jaegeuk at ~9/26/2015. I can't remember the time when this commit is removed from dev branch which is for -next branch. I have checked next-20151022, this commit is gone, I think the last -next will not make any trouble to you. Could you check that? > ^ > fs/f2fs/checkpoint.c:143:5: note: declared here > int ra_meta_pages(struct f2fs_sb_info *sbi, block_t start, int nrpages, > ^ > scripts/Makefile.build:258: recipe for target 'fs/f2fs/checkpoint.o' failed > make[2]: *** [fs/f2fs/checkpoint.o] Error 1 > > Looks like this commit: > > commit 26879fb101f28c554294eaf25ac7817a2825b180 > Author: Chao Yu > Date: Mon Oct 12 17:05:59 2015 +0800 > > f2fs: support lower priority asynchronous readahead in ra_meta_pages > > missed updating one call. Apparently this wasn't compile-tested before > being pushed upstream? When this commit was updated in Jaegeuk's tree, above invoking in fs/f2fs/checkpoint.c:707 was gone. Thanks,