From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2] crypto - img-hash: Depend on OF and silence compile test warning
Date: Sat, 25 Mar 2023 12:01:47 +0100 [thread overview]
Message-ID: <03009090-e1e9-a176-c629-dee99993e9ad@linaro.org> (raw)
In-Reply-To: <ZB6NxI9/llX7oFdg@gondor.apana.org.au>
On 25/03/2023 06:59, Herbert Xu wrote:
> On Fri, Mar 24, 2023 at 11:51:43AM +0100, Krzysztof Kozlowski wrote:
>>
>>> You should either add a dependency on OF or __maybe_unused.
>>> Adding both makes no sense.
>>
>> Of course it makes, otherwise you have warnings which is also fixed here.
>
> It won't create a warning if you depend on OF without COMPILE_TEST.
In that case yes, but we want COMPILE_TEST for build coverage.
>
> Anyway, I think adding __maybe_unused by itself is sufficient.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-25 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 14:44 Krzysztof Kozlowski
2023-03-24 10:16 ` Herbert Xu
2023-03-24 10:51 ` Krzysztof Kozlowski
2023-03-25 5:59 ` Herbert Xu
2023-03-25 11:01 ` Krzysztof Kozlowski [this message]
2023-03-26 2:53 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03009090-e1e9-a176-c629-dee99993e9ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®