From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932927AbdEKNsS (ORCPT ); Thu, 11 May 2017 09:48:18 -0400 Received: from mout.web.de ([212.227.15.14]:53431 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755504AbdEKNrg (ORCPT ); Thu, 11 May 2017 09:47:36 -0400 Subject: [PATCH 2/4] C6X/megamode-pic: Delete an error message for a failed memory allocation in init_megamod_pic() From: SF Markus Elfring To: linux-c6x-dev@linux-c6x.org, Aurelien Jacquiot , Mark Salter Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <1b8c2efb-1096-3b78-9100-e20c55b6ecf1@users.sourceforge.net> Message-ID: <03061c31-8a58-59a4-e76a-a4380e7a1935@users.sourceforge.net> Date: Thu, 11 May 2017 15:47:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1b8c2efb-1096-3b78-9100-e20c55b6ecf1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:FLBwovvM3guHCQQ6TMGfTtKRS+ibHekV4NJMuHi2xw4vdnXfGT4 Jvwzw8ydqrQKUTrNk/wEMFW1mqdG/jm9RtK32G3jpohuzL8vVtonJ5UK8LkZ9Phr3Dyyt2K U2bCmxqqGlgpgfw2RVz6rT4J9xu6CgvKctXMF55hQiRefUVo/+TOuWwfxNbtzJXt0wnNFN6 CZ65MMc5b7pTF/9w9s9GA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Doh6Pk0b/YI=:gREs5+FiWe5d3gJPAn4rWh CN4OYD4fa2eDTDebfiiCoPACKy6QIAlb29d5SMdMbbnl/1AutmXAnLYrPQGv3/EyxNHo3xzxF KFt2ulFgLPE/nGAPwhoufH1gscgKz3sjpkxUr1lEe+mTck6tYtTZWGnT9DdZExHTM2WVpQHJc wEhZb6P6Qrqo8cTv4+CLwY7nybDnB7t7kmapr+2yh6otXyAxgtL68edGhNSUethVAvFcLm5hf Zo1HwHUdRijDTU7UOtLtXFO5YBogglJcLkIWV6zB2brFkkRtMb8Jj+PA0kVyn7reRu/sXR7Vp bRPmkOzqQ3tGfJaM74mVEl7iMGQ5CvhAn9JaX+yMEdk7wM2+VWwiqPqvLJOdPnKovGAgva/v+ FsossigA8AcbT0iziV7+W2aEIZagnpD7qhYpVV7UMF0G7c2SCLJkDz22TZoTCrFP4Ff92tKVd cMv5LG1X4XKO8vRY9Od0AsIlmhxXo8y/8Y8wS0s5mPRCDVc7DbIG6En8kSSuY/mXR1FyX5pAK VJ1SlJcfa6ZcK3s53QSvB30y3s4SooQqmbAxNDd1ErCBGIFu81uvOh9MGrPJRjZcM9cKGzrsN y5tRrMy2FmQwuBzLa5xuEtszH1FTKAPeVhTbdzgt56XkUq448JWrEFc3PZIfX/sTz4pcm8M6J F6OJavm7PMGAT4GWcAZGISnsMGQfefOzhm8qHahV7cBkAPb+Jk/pOUvQCoi5m8FNX/HKdUBd/ ikJRcijfkhJQmYT1mLL0MBp8j/2Fi9zoOi0o2NkZVSy1qdgy4S3xoBYwRvo5UP3/zJHv52uwg FOjKkvx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 11 May 2017 15:00:30 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/c6x/platforms/megamod-pic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/c6x/platforms/megamod-pic.c b/arch/c6x/platforms/megamod-pic.c index 72b5f143c105..cf0ebf25e42f 100644 --- a/arch/c6x/platforms/megamod-pic.c +++ b/arch/c6x/platforms/megamod-pic.c @@ -209,7 +209,5 @@ static struct megamod_pic * __init init_megamod_pic(struct device_node *np) - if (!pic) { - pr_err("%s: Could not alloc PIC structure.\n", np->full_name); + if (!pic) return NULL; - } pic->irqhost = irq_domain_add_linear(np, NR_COMBINERS * 32, &megamod_domain_ops, pic); -- 2.12.3