From: Florian Fainelli <f.fainelli@gmail.com>
To: Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BRCMSTB I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts
Date: Mon, 18 Jul 2022 17:15:25 -0700 [thread overview]
Message-ID: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> (raw)
In-Reply-To: <YtKxpz7kiER8ydcj@shikoro>
On 7/16/2022 5:40 AM, Wolfram Sang wrote:
> On Wed, Jul 06, 2022 at 10:21:15AM -0700, Florian Fainelli wrote:
>> When the adapter is registered without interrupts, we would be showing
>> the following:
>>
>> # i2cdetect -l
>> i2c-3 i2c Broadcom STB : I2C adapter
>
> What about switching to pdev->name here? That way you also get the base
> address for free to differentiate if there are multiple instances on the
> SoC?
I was not sure if we could change the adapter name reported as one could
argue this is now ABI, but if we can, then using dev_name() is probably
better. You are the maintainer you so know the rules on what is
considered stable ABI and what is not :)
--
Florian
next prev parent reply other threads:[~2022-07-19 0:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 17:21 Florian Fainelli
2022-07-16 12:40 ` Wolfram Sang
2022-07-19 0:15 ` Florian Fainelli [this message]
2022-07-19 3:57 ` Wolfram Sang
2022-07-19 4:06 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03065912-a9f0-6380-6f19-9db2f43be589@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®