From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7822FFDFC
	for <linux-kernel@vger.kernel.org>; Wed, 25 Feb 2026 06:43:21 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1772001803; cv=none; b=IMOiDjQ4zul5+whtkKr76aeyiMYcN60aeLliL8wwBNMhTAIWBjTUJhhNDotCQqUwYdQTOEqoHgjXYE/r0L2HG6tLftrn394t6lbnDtxynR4MIqYFZ2HsYLg35u4D9doiXAvccTh8A/fXq6+nKgdlB2FM2t/XU06WfdAGGdqhww8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1772001803; c=relaxed/simple;
	bh=kD6AmYfHaV7ToltQOuWaaK+gQqZuth//RER0iQeyBnI=;
	h=Message-ID:Subject:From:To:Date:In-Reply-To:References:
	 Content-Type:MIME-Version; b=P3K9npI9CVGeb35BuhV8ytugm+jMtkVpU6182Li0um8dICpWPxNwFFwbDiGoqVzQWbW+DJ+ddqelHM5XQ08bKC7EqmxSjU6DERRJ+EZbXcmE3YDp3Rf7JRW9O1+iY1Qx4CK85YmXfKxKSLX2GiZ+OsWqgObzV+GqFqtatM+G0WM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=fYRv4LSl; arc=none smtp.client-ip=203.29.241.158
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="fYRv4LSl"
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=codeconstruct.com.au; s=2022a; t=1772001798;
	bh=kD6AmYfHaV7ToltQOuWaaK+gQqZuth//RER0iQeyBnI=;
	h=Subject:From:To:Date:In-Reply-To:References;
	b=fYRv4LSl4LDULvDMUP84fFFloabm2UA3YXZSPbwZFDtV9hvwTf07JkHidz47kJZoA
	 wf0EhBhKOJ220jz8Qnr48XdOEBKocAbdXxIyRxQgaMZR2isULhsgQwdu7Y9dGYoRh6
	 4sWuAxJxF6LKk85fry0xSxruhfQsAVkSVXZ7r8RyncydW9CCqmGepW+ZHnhmQ3QZQv
	 XEiHG+1cAJ2bHULliuj4rV9PlDU6H2dSGbQ7tdpRDoBg0nBIOCgKP4+RdUxEs9xQoQ
	 K9tIKzYaKbFg1QFm2ukQnQbuU52wSm/VidtX/zsOK5VOk7SdrYXyVXihY4Yo5Xo/Lb
	 mcioucb01PMDg==
Received: from pecola.lan (unknown [159.196.93.152])
	by mail.codeconstruct.com.au (Postfix) with ESMTPSA id D88DF6023B;
	Wed, 25 Feb 2026 14:43:17 +0800 (AWST)
Message-ID: <0307499b99c3ea9280ea2d6b9c3e325aeec46a0d.camel@codeconstruct.com.au>
Subject: Re: [PATCH v1] i3c: master: ast2600: Fix missing of_node for
 virtual I2C adapter
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Peter Yin <peteryin.openbmc@gmail.com>, Alexandre Belloni
	 <alexandre.belloni@bootlin.com>, Frank Li <Frank.Li@nxp.com>, 
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Date: Wed, 25 Feb 2026 14:43:17 +0800
In-Reply-To: <20260225063529.3230676-1-peteryin.openbmc@gmail.com>
References: <20260225063529.3230676-1-peteryin.openbmc@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2+deb12u1 
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0

Hi Peter,

> The ASPEED AST2600 I3C master driver creates a virtual I2C adapter to
> provide backward compatibility with I2C devices. However, the current
> implementation does not associate this virtual adapter with any
> Device Tree node.
>=20
> This patch propagates the of_node from the I3C master platform device
> to the virtual I2C adapter's device structure. This ensures that
> standard I2C aliases are correctly resolved and bus numbering remains
> consistent across reboots.

Sounds sensible - but:

> --- a/drivers/i3c/master/ast2600-i3c-master.c
> +++ b/drivers/i3c/master/ast2600-i3c-master.c
> @@ -156,6 +156,7 @@ static int ast2600_i3c_probe(struct platform_device *=
pdev)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0i3c=
->sda_pullup);
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0i3c->dw.platform_ops =3D =
&ast2600_i3c_ops;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0i3c->dw.base.i2c.dev.of_node =
=3D np;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return dw_i3c_common_prob=
e(&i3c->dw, pdev);
> =C2=A0}

Why not do this in the common (dw) driver? Nothing about the of_node
association is aspeed-specific.

Cheers,


Jeremy