From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76FFDC77B73 for ; Wed, 31 May 2023 06:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234300AbjEaGm5 (ORCPT ); Wed, 31 May 2023 02:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbjEaGmz (ORCPT ); Wed, 31 May 2023 02:42:55 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D324CBE; Tue, 30 May 2023 23:42:52 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 8398024DDBE; Wed, 31 May 2023 14:42:51 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:42:51 +0800 Received: from [192.168.125.80] (113.72.147.198) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:42:50 +0800 Message-ID: <0308ad78-5aec-f51f-41d1-40364d87ddc3@starfivetech.com> Date: Wed, 31 May 2023 14:42:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v5 3/3] riscv: dts: starfive: add the node and pins configuration for tdm Content-Language: en-US To: Walker Chen , Mark Brown , Liam Girdwood , Claudiu Beznea , Jaroslav Kysela , "Takashi Iwai" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" CC: , , , References: <20230526145402.450-1-walker.chen@starfivetech.com> <20230526145402.450-4-walker.chen@starfivetech.com> From: Hal Feng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.147.198] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 31 May 2023 14:30:19 +0800, Walker Chen wrote: > On 2023/5/31 14:23, Hal Feng wrote: >> On Fri, 26 May 2023 22:54:02 +0800, Walker Chen wrote: >>> Add the tdm controller node and pins configuration of tdm for the >>> StarFive JH7110 SoC. >>> >>> Signed-off-by: Walker Chen >>> --- >>> .../jh7110-starfive-visionfive-2.dtsi | 40 +++++++++++++++++++ >>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 21 ++++++++++ >>> 2 files changed, 61 insertions(+) >>> >>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> index 1155b97b593d..19b5954ee72d 100644 >>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >>> @@ -214,6 +214,40 @@ >>> slew-rate = <0>; >>> }; >>> }; >>> + >>> + tdm0_pins: tdm0-pins { >>> + tdm0-pins-tx { >> >> Use consistent naming, so >> >> tdm_pins: tdm-0 { >> tx-pins { >> >>> + pinmux = >> + GPOEN_ENABLE, >>> + GPI_NONE)>; >>> + bias-pull-up; >>> + drive-strength = <2>; >>> + input-disable; >>> + input-schmitt-disable; >>> + slew-rate = <0>; >>> + }; >>> + >>> + tdm0-pins-rx { >> >> rx-pins { >> >>> + pinmux = >> + GPOEN_DISABLE, >>> + GPI_SYS_TDM_RXD)>; >>> + input-enable; >>> + }; >>> + >>> + tdm0-pins-sync { >> >> sync-pins { >> >>> + pinmux = >> + GPOEN_DISABLE, >>> + GPI_SYS_TDM_SYNC)>; >>> + input-enable; >>> + }; >>> + >>> + tdm0-pins-pcmclk { >> >> pcmclk-pins { >> >>> + pinmux = >> + GPOEN_DISABLE, >>> + GPI_SYS_TDM_CLK)>; >>> + input-enable; >>> + }; >>> + }; >>> }; >>> >>> &uart0 { >>> @@ -221,3 +255,9 @@ >>> pinctrl-0 = <&uart0_pins>; >>> status = "okay"; >>> }; >>> + >>> +&tdm { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&tdm0_pins>; >> >> pinctrl-0 = <&tdm_pins>; >> >> Best regards, >> Hal > > OK, I'll update these node's name in the next submit. > Thanks. With that fixed, Reviewed-by: Hal Feng Best regards, Hal