From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17533E7159 for ; Thu, 11 Jun 2026 11:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781177452; cv=none; b=I0T4qZ9JJK5lLVDIcl0lzXRRCLmIxgTJPtfJd1h4PUs+um4qh4QMyCj8xz861cmuuItGfLuW9jmEUtV9tsab74qvtMUVHcIg7x6gEDBrlXNt5PMnINdPQCdvp+M+ZgO/dyjB0BIJ4BpJ8xDpkqKUpV4FnWXEmvekyUxWXZKcDlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781177452; c=relaxed/simple; bh=+ZhNOVLruR0M0mTHrO9GLNDrZvneFHLHmhER8H2zKNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZPaHP/CkXynAIti9vyzqSskRQFCkf4iXXHPyhzhmejV89C0+6Rw+TbEswQ7j0nH+W43sKLUGMRNUo3OeEx3NjYO6ZqJzf1TnaDcT2e18MeceRc+vZDVszoQQhwd9fttF7qB7gbTbqfO7FQXqL3jAwpt/wK69MSt8NgiXwXyZXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=prdBi3tZ; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="prdBi3tZ" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-137335bc3caso10046241c88.0 for ; Thu, 11 Jun 2026 04:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781177450; x=1781782250; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Gt1P0is49RL6xipZvRdGAPlsRQ5LygLoU9uhWeqmWIE=; b=prdBi3tZqsTr8UlTgfB5pRrhA2G7EWtQKysjr1FFIN+ZaMIFYRzkwi7V/qFDql03ZB /0G6zEqoG/2yHp3U4xfH1fjgCi6ZSQg/OHo4E24VUz84Mvkh0A9dSbcCTpYVTNmr6pAC P+AwhCUmN4ygQ4wNNgKLZXkwMDH02FAm2tazmThRMLkHS+Jrvc4WcYBTkRZhP9PQLxUJ bhyvyCipDQfyn6VnSEszAbrC0f3dmdwHcECYlBaou5/734BR/UJzJJasGOAb8YSeeKtn 1TDjniPPis6ScSrOOffpEXch1NGvpoxZjXZMpQH+WI9QzcgSJ7Z0/iaWUX4Bo5DY4aoK +b7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781177450; x=1781782250; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Gt1P0is49RL6xipZvRdGAPlsRQ5LygLoU9uhWeqmWIE=; b=T4QdlCxtIKryVHYK+J+Pau1xPzEMaksldBuWPgoY3Kvb7Ty86A4PUoEexbUcWVWldF buOzpoJ9EwMIKdA+4DVeu8co73ufE7cJ2ulx6XbdXpmxc9rLphGwnUrSU27O9/nEWMGF NTrR/bDLnYzwfyyM2jzcAffFMyDNmDbPlRERzLuCr7+jS/CtjQZWYlSRevD7H9FwcLje x1Z+YAlMqF+0/uNtnqHweiOenuLKWezVdY2BKngNuHj/1mcaXbe9txLpUayVNda5xxe9 rCpwEFR8TxGPDRXyiyXA2MggnZYhzijGIGwc4kEUG7K4U0omL+eV7Jm68HFOJZqeYTTF AxVw== X-Forwarded-Encrypted: i=1; AFNElJ9S1IVOJBbL3UPdYWY9DRVUFJtYi+QqluD23C2xVCWLt7r8arhrkbweBGfAa7kdPJoDtwKAGJ1z7a2SsJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YzHZJDBrkxIhkGwmBmC00drTE//vcF7+NMFflSxRRc2p76yyJuj eWmPumKQ71i6cDEnznt5nfeonkHNrHVT5t7Cz9Nt43z5jxXE4zW3BAGh X-Gm-Gg: Acq92OH6xnh6qoRtGwfkj/JWvwaocGH530Gl/eFOjoHxlgJ0yXIeJL+JEn+Bk+7jkep btVoUuOcS+45mJNHc9f0/RwF6GHo008PVrCwcNZDiraUh/dAASxTzM9PjC1eZ/6XWBk2djg84cA XMjWAyskDxywsAQPl28a3WU92fVdSNAqJkTK3viOXubJFq5dqykQZaQG5MVpUekzuv4tTXQKfU5 ziSYneX7dmL18B3i0zmzl0lhxyFKE60rzLRjvG8SAb8zmADd6+6GVuzOpKNKntxOdUqSdtIVixi estcuG5FELsqA3fZKFZu2jNv/NKV70DtO2E28NWJlMUZ0g4KDfCW4UfT5Q7KZn4fKFmVlqJETFL UQSHARKc0SY+/l6TDAqcjoBlmh4c5ZIx8Pk5moXpO03ejE4u2lG8y3KHxxmVpG45GqIYoq8tjXb ycHemJ0c8fSDlViSzsnKRZxrPfYMJJS0aAM2kolsMyL3aq6Tj5kfKFC9F2/g== X-Received: by 2002:a05:701b:4183:20b0:136:b370:64c5 with SMTP id a92af1059eb24-138422d9798mr1007059c88.30.1781177449785; Thu, 11 Jun 2026 04:30:49 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30806c2f0acsm2167278eec.1.2026.06.11.04.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 04:30:49 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 11 Jun 2026 04:30:48 -0700 From: Guenter Roeck To: Potin Lai Cc: Patrick Williams , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmo Chou , Mike Hsieh , Potin Lai Subject: Re: [PATCH v3] hwmon: (pmbus/lm25066) Fix PMBus coefficients for LM5064/5066/5066i Message-ID: <030e2e3e-7e37-4944-b901-c0c6faf6b063@roeck-us.net> References: <20260611-lm25066-driver-fix-v3-1-9d7d4b4e253d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260611-lm25066-driver-fix-v3-1-9d7d4b4e253d@gmail.com> On Thu, Jun 11, 2026 at 01:46:18PM +0800, Potin Lai wrote: > Swap the high setting and low setting coefficients in the lm25066_coeff > table for LM5064, LM5066, and LM5066i. The coefficients were previously > mapped incorrectly, resulting in inverted current and power scaling. > > Additionally, dynamically assign the exponent (R) registers inside the > probe's LM25066_DEV_SETUP_CL check. This ensures that the proper > exponent is applied (e.g., for LM25056, high setting power exponent > is -4, but low setting power exponent is -3). > > Signed-off-by: Potin Lai Applied. Thanks, Guenter