From: Jon Hunter <jonathanh@nvidia.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
Robert Moore <robert.moore@intel.com>,
Erik Kaneda <erik.kaneda@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>
Cc: <clang-built-linux@googlegroups.com>, Len Brown <lenb@kernel.org>,
<linux-acpi@vger.kernel.org>, <devel@acpica.org>,
<linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
Date: Thu, 21 Jan 2021 10:06:12 +0000 [thread overview]
Message-ID: <031790d7-ee26-f919-9338-b135e9b94635@nvidia.com> (raw)
In-Reply-To: <20201111021131.822867-1-ndesaulniers@google.com>
On 11/11/2020 02:11, Nick Desaulniers wrote:
> The "fallthrough" pseudo-keyword was added as a portable way to denote
> intentional fallthrough. This code seemed to be using a mix of
> fallthrough comments that GCC recognizes, and some kind of lint marker.
> I'm guessing that linter hasn't been run in a while from the mixed use
> of the marker vs comments.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
I know this is not the exact version that was merged, I can't find it on
the list, but looks like the version that was merged [0], is causing
build errors with older toolchains (GCC v6) ...
/dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function ‘acpi_ds_exec_begin_control_op’:
/dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error: ‘ACPI_FALLTHROUGH’ undeclared (first use in this function)
ACPI_FALLTHROUGH;
^~~~~~~~~~~~~~~~
/dvs/git/dirty/git-master_l4t-upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each undeclared identifier is reported only once for each function it appears in
/dvs/git/dirty/git-master_l4t-upstream/kernel/scripts/Makefile.build:287: recipe for target 'drivers/acpi/acpica/dscontrol.o' failed
Cheers
Jon
[0] https://github.com/acpica/acpica/commit/4b9135f5
--
nvpublic
next prev parent reply other threads:[~2021-01-21 10:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 2:11 Nick Desaulniers
2020-11-11 15:15 ` Moore, Robert
2020-11-11 18:48 ` Nick Desaulniers
2020-11-12 15:13 ` Moore, Robert
2020-11-12 19:30 ` Nick Desaulniers
2020-11-12 20:22 ` Joe Perches
2020-11-12 21:47 ` Moore, Robert
2020-11-13 0:09 ` Nick Desaulniers
2020-11-13 8:14 ` Miguel Ojeda
2020-11-13 16:29 ` Joe Perches
2020-11-13 21:01 ` Moore, Robert
2020-11-13 21:04 ` Nick Desaulniers
2020-11-13 21:00 ` Nick Desaulniers
2020-11-13 8:10 ` Miguel Ojeda
2020-11-13 21:27 ` Moore, Robert
2020-11-13 21:32 ` Nick Desaulniers
2020-11-13 21:42 ` Moore, Robert
2020-11-13 21:43 ` Nick Desaulniers
2020-11-13 21:43 ` Moore, Robert
2020-11-13 21:45 ` Moore, Robert
2020-11-13 22:09 ` Nick Desaulniers
2020-11-13 22:12 ` Moore, Robert
2021-01-21 10:06 ` Jon Hunter [this message]
2021-01-21 19:03 ` Rafael J. Wysocki
2021-01-21 19:07 ` Nick Desaulniers
2021-01-21 22:05 ` Kaneda, Erik
2021-01-21 22:28 ` Kaneda, Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031790d7-ee26-f919-9338-b135e9b94635@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=gustavoars@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®