From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C57CC43334 for ; Tue, 12 Jul 2022 11:57:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232417AbiGLL5s (ORCPT ); Tue, 12 Jul 2022 07:57:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233035AbiGLL5X (ORCPT ); Tue, 12 Jul 2022 07:57:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2221BB38CE for ; Tue, 12 Jul 2022 04:57:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657627039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=olaRyc5m79LX2YhKauQNe+T3doYLi+ybnhrejxK98CE=; b=TJ1AxfvxO6K1rnNK4A9c/Bv0dApp/g7D/rfJtq4bEGomcrNMuPGKJtbhJYPgON5WNInuFC InREvzyXccyp9IHk1rx5sKo3WilEaTHoiLNaJ7/SBA90RfPEaREWYvp8E68fTrv8TPdd7U CtRFa7t8qAO8xXxM2UsaXiRMF8OfJyA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-WY-tafRiOEG3M7QfY6TYdA-1; Tue, 12 Jul 2022 07:57:17 -0400 X-MC-Unique: WY-tafRiOEG3M7QfY6TYdA-1 Received: by mail-qk1-f198.google.com with SMTP id bm2-20020a05620a198200b006a5dac37fa2so7620848qkb.16 for ; Tue, 12 Jul 2022 04:57:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=olaRyc5m79LX2YhKauQNe+T3doYLi+ybnhrejxK98CE=; b=liqYUcZcO3QG3Ur8J7+hmIWzcg/gt8lti7eP05ikdo9od0yuWG15bhAawdk3czpCam 8PdPiSqloC80gJo3+oNUC/yFby85inWeucsofeHElvkIqYWQ6n6+wUI/fnLwRNwcj+L+ Ri3q8p0eSMtj8adOqo/yjg2XW8bCpIWAiJx3T6oqlT85rh+Mbnc5UjkAd04V3oZdTX4j tphCeWIjKZ3vy5LdUJq577JViqA6ksWVRStmCNZEivhlvFK5Jrzo1qDnEOTNR1JOdx8i IDZvrK7A6OAcg+YO0iPRBi4DAtbRAog5IXa+d9etB2CnZEcoEhTg0YYS2HnEKPfZq5sx iR2g== X-Gm-Message-State: AJIora+ONk24PTvsNIgdYiQ1oDst2W5G9IzkOADbOxDs/fHzCmYHjMzr KFElv4iVBl5IqhXbJBe7Eksz4C1F6picqD5S+fBgbbfYl6a4vDFtUBLNKr0iGVYXhmgnSpadczM m3pnxQllcvhstLyzldqj+n3UM X-Received: by 2002:ac8:5a4a:0:b0:31e:c15f:c1f9 with SMTP id o10-20020ac85a4a000000b0031ec15fc1f9mr1802434qta.12.1657627037539; Tue, 12 Jul 2022 04:57:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1urHh4ODy0b6XiDk4WThbx6/yS3IFDPugQq8wMUsZi0/m+3IrBehtXOQ128Owji6o19BTZj8A== X-Received: by 2002:ac8:5a4a:0:b0:31e:c15f:c1f9 with SMTP id o10-20020ac85a4a000000b0031ec15fc1f9mr1802350qta.12.1657627036023; Tue, 12 Jul 2022 04:57:16 -0700 (PDT) Received: from [10.35.4.238] (bzq-82-81-161-50.red.bezeqint.net. [82.81.161.50]) by smtp.gmail.com with ESMTPSA id n7-20020ae9c307000000b006a34a22bc60sm8400241qkg.9.2022.07.12.04.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 04:57:15 -0700 (PDT) Message-ID: <031867fe65f26f7e2d37cc41ec071b3aea98ee90.camel@redhat.com> Subject: Re: [PATCH v3 17/25] KVM: VMX: Add missing VMEXIT controls to vmcs_config From: Maxim Levitsky To: Vitaly Kuznetsov , kvm@vger.kernel.org, Paolo Bonzini , Sean Christopherson Cc: Anirudh Rayabharam , Wanpeng Li , Jim Mattson , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 Jul 2022 14:57:11 +0300 In-Reply-To: <20220708144223.610080-18-vkuznets@redhat.com> References: <20220708144223.610080-1-vkuznets@redhat.com> <20220708144223.610080-18-vkuznets@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-5.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-07-08 at 16:42 +0200, Vitaly Kuznetsov wrote: > As a preparation to reusing the result of setup_vmcs_config() in > nested VMX MSR setup, add the VMEXIT controls which KVM doesn't > use but supports for nVMX to KVM_OPT_VMX_VM_EXIT_CONTROLS and > filter them out in vmx_vmexit_ctrl(). > > No functional change intended. > > Reviewed-by: Jim Mattson > Signed-off-by: Vitaly Kuznetsov > --- >  arch/x86/kvm/vmx/vmx.c | 4 ++++ >  arch/x86/kvm/vmx/vmx.h | 3 +++ >  2 files changed, 7 insertions(+) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index d7170990f469..2fb89bdcbbd8 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -4196,6 +4196,10 @@ static u32 vmx_vmexit_ctrl(void) >  { >         u32 vmexit_ctrl = vmcs_config.vmexit_ctrl; >   > +       /* Not used by KVM but supported for nesting. */ > +       vmexit_ctrl &= ~(VM_EXIT_SAVE_IA32_PAT | VM_EXIT_SAVE_IA32_EFER | > +                        VM_EXIT_SAVE_VMX_PREEMPTION_TIMER); > + >         if (vmx_pt_mode_is_system()) >                 vmexit_ctrl &= ~(VM_EXIT_PT_CONCEAL_PIP | >                                  VM_EXIT_CLEAR_IA32_RTIT_CTL); > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index 89eaab3495a6..e9c392398f1b 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -498,8 +498,11 @@ static inline u8 vmx_get_rvi(void) >  #endif >  #define KVM_OPT_VMX_VM_EXIT_CONTROLS                           \ >               (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL |             \ > +             VM_EXIT_SAVE_IA32_PAT |                           \ >               VM_EXIT_LOAD_IA32_PAT |                           \ > +             VM_EXIT_SAVE_IA32_EFER |                          \ >               VM_EXIT_LOAD_IA32_EFER |                          \ > +             VM_EXIT_SAVE_VMX_PREEMPTION_TIMER |               \ >               VM_EXIT_CLEAR_BNDCFGS |                           \ >               VM_EXIT_PT_CONCEAL_PIP |                          \ >               VM_EXIT_CLEAR_IA32_RTIT_CTL) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky