From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757017AbbJVKXw (ORCPT ); Thu, 22 Oct 2015 06:23:52 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:40506 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbJVKXv (ORCPT ); Thu, 22 Oct 2015 06:23:51 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-06-5628b9356992 From: Chao Yu To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] f2fs: fix error path of ->symlink Date: Thu, 22 Oct 2015 18:23:08 +0800 Message-id: <031901d10cb3$bdff27b0$39fd7710$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdEMswhusj5TB0mpQLmshDh8jBY5lw== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jAV3TnRphBvuXalk8WT+L2eLSIneL y7vmsDkwe2xa1cnmsXvBZyaPz5vkApijuGxSUnMyy1KL9O0SuDKm/9rEVrCSs+LEkg6WBsZ9 7F2MHBwSAiYSJyfxdzFyApliEhfurWfrYuTiEBJYyijx+0sXlPOKUWLX2y2MIFVsAioSyzv+ M4HYIkD2oUWX2UFsZgEPicaO76wgtrCAmcTsg9OZQWwWAVWJnx9fgtXwClhKPF+6HMoWlPgx +R4LRK+WxPqdx5kgbHmJzWveMkNcpCCx4+xrRohdehILPy1khagRl9h45BbLBEaBWUhGzUIy ahaSUbOQtCxgZFnFKJFakFxQnJSea5iXWq5XnJhbXJqXrpecn7uJERzEz6R2MB7c5X6IUYCD UYmH98If9TAh1sSy4srcQ4wSHMxKIryXpmqECfGmJFZWpRblxxeV5qQWH2KU5mBREue9kAGU EkhPLEnNTk0tSC2CyTJxcEo1MMYZP9rZvsUxR/xzYrz/HesZcjw5fPcPea3SVDxXI70iMjTy 5kvGCvPFpxc81xeWDvM+5+dlOnNfpMmBJU0OEzjWW3365vLoTMJU1yeXGkPPvbWJ9Nizcp+b lWV4T9NLN//o5W/kzRR4GHzePLBVma5svI5H6T+32uXdHbyJx4VNn3aHWl2ZrMRSnJFoqMVc VJwIAIHD6yteAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now, in ->symlink of f2fs, we kept the fixed invoking order between f2fs_add_link and page_symlink since we should init node info firstly in f2fs_add_link, then such node info can be used in page_symlink. But we didn't fix to release meta info which was done before page_symlink in our error path, so this will leave us corrupt symlink entry in its parent's dentry page. Fix this issue by adding f2fs_unlink in the error path for removing such linking. Signed-off-by: Chao Yu --- fs/f2fs/namei.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index dfa01c8..e48b80c 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -410,11 +410,14 @@ err_out: * If the symlink path is stored into inline_data, there is no * performance regression. */ - if (!err) + if (!err) { filemap_write_and_wait_range(inode->i_mapping, 0, p_len - 1); - if (IS_DIRSYNC(dir)) - f2fs_sync_fs(sbi->sb, 1); + if (IS_DIRSYNC(dir)) + f2fs_sync_fs(sbi->sb, 1); + } else { + f2fs_unlink(dir, dentry); + } kfree(sd); f2fs_fname_crypto_free_buffer(&disk_link); -- 2.6.1