From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5298D1D7E42 for ; Fri, 12 Dec 2025 05:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765517731; cv=fail; b=p8Xh6EAQ0+elRxFfj634TC+X/uC3Hm9oy8fZFaXPl87baTF5VQ47p9FrpN32G2TmhK0ZHGV5BRDgHqv2QH8MIxYH4n5rFTpd35lwyvaWqWVWxOMFRU3/ZT4gZEGwzuIeyBkVkoCaw93af+L1uRNaZ4lAKmTCCM799MEZs4hPggE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765517731; c=relaxed/simple; bh=/zSgI3GauOdiCguMOqqOHDS9hlBjC/WJwbapMRJNjOM=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=f5cq4s7JmAOfK9Pv+Kdpc0rRzVmHKj/WgrD3taJWH5R3I0DzoO42SjUtG00WAVWbjdoXLWGQZw6StiTQoxfTDiikm/xqjsRJapikRtDEVnhIpZtvkcGJbJSLWhXorORZHNiuivIbCkg8G0DbpXgg79tLac0d1rQAXRc3uyhZAs4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YKgVk45r; arc=fail smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YKgVk45r" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765517729; x=1797053729; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=/zSgI3GauOdiCguMOqqOHDS9hlBjC/WJwbapMRJNjOM=; b=YKgVk45r5JZteIObYvROTW9UhWNV8lQRZzDVGgiK+FpEIfPb365ZmuuK Xyxk+dyTBgomym3AsTJ05cPRXJ0F7aKSxgYRBk+I3LhgpNBGhDyNDgvG3 kcMm1BkTkrQOw4niwtld4xbkl6Ns4fDIFs0ysthlcq2MELc9CyX2pljd0 vzzxchHMhHvF+wnFYlzHL4+fIw4Fu5TbXbRMdiE0rSlnsQAjlEl3TC130 R+jN67/TSapKJS1cpjZQ5Eo3aBED020HXxb5HYYEDKFULGo4YV2d2RbPF ijqhCJYxg2BrjRyZTWvQTJxHXQlHvm5QQE5Fx8n8MVA0LHoPnpM+Sg1Nl w==; X-CSE-ConnectionGUID: gexYM5D0Qa+MOLF/P706Bg== X-CSE-MsgGUID: 356/RgwSQ+K6B3M+tKRUwA== X-IronPort-AV: E=McAfee;i="6800,10657,11639"; a="71351858" X-IronPort-AV: E=Sophos;i="6.21,141,1763452800"; d="scan'208";a="71351858" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 21:35:28 -0800 X-CSE-ConnectionGUID: TkS/1esLQ9yAK1ZoHOp7Ng== X-CSE-MsgGUID: LkFz4RN/QxCtHw9si0LCXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,141,1763452800"; d="scan'208";a="196280093" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 21:35:28 -0800 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 11 Dec 2025 21:35:27 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Thu, 11 Dec 2025 21:35:27 -0800 Received: from CH1PR05CU001.outbound.protection.outlook.com (52.101.193.47) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 11 Dec 2025 21:35:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OyzWBni6jZGHn9s3RFd02339E/wOpYWjrrtBsdDfQnu9vLOo6pdKsq1NyK69GoAud3Roy49TN/PA8BXk4bBjTW80C+I/itLGyGhjlQqEoDGahQ4t+JQGTUN2zkkgrLQBIfX7P88TAN2pq8owzNvGUnG0S/dpej/P11kFV+hJERKWOxZk9pevlmt4f+wxjpA9aFF2gTNTAB54DQ4JQYp/pCPLUDoRZ5WBTF1x6r2FHHoSXDNLxfrECB5rdI4KcnwIIi+LkwB9OQkG8BMjP/dDhM7O/llaV+D5SNcbLc4kfW+X0x/93zP4E6B57fdvtylIpbDquC4YxRokUZcrbrpZjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cmptja4g3FvCasB5ivGWdttTB0CHkJlYouksm6LF64I=; b=XR7JkuuUwh1rfHj4TGeTqLr0pknl8HGJkfTcjoiyfb8ApqkTuZlGiM7mp3+spIkWDWePAdIe9qxcEW14Y0oAAhllblH1BR1qSNc74CQUGb2b4n/BpxxSOhQ/WGH1k9rTio9XprTXkFvKGUTwHH1+5OTZaaX9bOGG2L0UymD7ElkUqVJaPZNiOnMa1AhzRrtPGHLP1dzbMLmWdP1oxbIekydepgb+L98ryBNNwiimhKRYAb2dY87OinWtdmwMfSwp6NW1H09Km1xaSr0KVyKgPxr5Q2Qg+VuTWaB1JwYwyFbmq8z20M95YsXo9690HAnCZqI7NfeEVb5HOrjQPOb9Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) by IA1PR11MB7811.namprd11.prod.outlook.com (2603:10b6:208:3f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.10; Fri, 12 Dec 2025 05:35:20 +0000 Received: from SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85]) by SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85%7]) with mapi id 15.20.9412.005; Fri, 12 Dec 2025 05:35:20 +0000 Message-ID: <031db8b9-846d-4fbd-bb5c-f28c860dffbe@intel.com> Date: Fri, 12 Dec 2025 13:35:12 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] mm/memory hotplug: fix zone->contiguous always false when hotplug To: Oscar Salvador CC: David Hildenbrand , Mike Rapoport , "Wei Yang" , , Yong Hu , Nanhai Zou , Yuan Liu , Tim Chen , Qiuxu Zhuo , Yu C Chen , Pan Deng , Chen Zhang , References: <20251208152544.1150732-1-tianyou.li@intel.com> <20251208152544.1150732-3-tianyou.li@intel.com> Content-Language: en-US From: "Li, Tianyou" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TPYP295CA0034.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::14) To MW4PR11MB8289.namprd11.prod.outlook.com (2603:10b6:303:1e8::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB8281:EE_|IA1PR11MB7811:EE_ X-MS-Office365-Filtering-Correlation-Id: 3689f800-09b9-415d-87cf-08de39403c9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aEdBTlRTNHlZWHh4MS91cU5kZUd2TWpNWHlBNFk2bzUzVTRjYkVaQmlPcUtz?= =?utf-8?B?ZklYekhlcjJ5Qmxtemd1dEYzNFR1bkJDRC9IQ0lBaW5Xcm90TkFFSXhTZ0Jy?= =?utf-8?B?STlwV3R5ZmUwUHJJV1ZoRG1hcWdxRllFRXlyNUNnL2pvZWFyZUxoMVlBQWlS?= =?utf-8?B?cGl2dnZaQThVcTYzc3MyTGVISlNrS2EyZll3UklHWTByU21QS3IrdlBvQnY4?= =?utf-8?B?MkRoMHdUUGo0UVVrM0hxYlNlYlgrbzBMVnFUZ2dFcFhhOXBLSjE1REZnMDAy?= =?utf-8?B?Q3NETWJzSTk5eTFLVHMzYkxMRkNLbndCM0NCUDNsUkhVMnFIVU52c1NIWEwx?= =?utf-8?B?M0ozMkhrMEJVY2JiQUJUSFYwc1BHenNLTjZFWXZrNGo4ZTBZNVpCQU5XcHJ6?= =?utf-8?B?SmR5Z0QwSURXSHlYSDF6N0ZtMkxEOHRJZ202THUyZC81bURrY2d0Szkwc2dU?= =?utf-8?B?SFRqOFprd0hUSlNTUDRzSUJrSVFzYWdyb21pYUQ5MFpsbDVMVEp2c2htNUJY?= =?utf-8?B?L0NHOXNkdDMwcXRNOXFVM2EvamtOcC80M0NkVnc5ZmZWWENLZDN3enliekNs?= =?utf-8?B?cDhtRFdPNkw2UGxyMDUxUXdSTFdLOTlqUE5md3dMMjNBdWppQlR1VEJCb2w3?= =?utf-8?B?VzJoNTY0alZKNUVORloyM3Zpb080aEpTeGtyUlNmQWpoa29HQVRJTjZXaFIr?= =?utf-8?B?QlE0ejIralpnSm0wUWJxTGVyVCtEWTdHTjJsenRGNFdXbStSOVRyRm9FUndU?= =?utf-8?B?SEdpZXNIMTgyb2U0djRnUFNtWEQyUmJ3WGl6d0dseWxOZVJpTEZNTFBhM2tZ?= =?utf-8?B?TXIvVmd5bHBPZGRFTWtRZkRCZHR2M3dxUS9GeVhHelJseElQMzAwU05vejU2?= =?utf-8?B?UkdLc3pBZmwrK3pZTGVwdjBsQ3QyWXpmQXhRRWtXWWF5R2JkQXgxZDdYNWxU?= =?utf-8?B?ZzhvT0dkbU96MHZaZkh5eExHaVkxWXV1dU1DMFZoWElnYWlRNDg5NVczN3JO?= =?utf-8?B?ZG9vb1hZN0RUNjMwdnAvcDJmUjJNRVdCRVR1akE2RmxWQmFBd1I0dndtNmxj?= =?utf-8?B?c3ZHN3l2dmJucE5QY1dHdHJOY1hwbWlQUmwzR2tTVGRYTnF3eGlGL2F1MUM3?= =?utf-8?B?dEU1bkNQZVRwZTZGcDhCU1haM0p6UzVRUUlteGNDQkl0WmhiaXRyREMvR2la?= =?utf-8?B?QURIN1ZXVUxFa09LcXRlUWkxS3RRTzRqNWZUOHBhbmdEb0ZwVXNXZTFIcmRY?= =?utf-8?B?MFIvVkd6MU96VUZ1T3JoOWV4UUd5MGovMjhVekcwTXNmN3BoY0J4bUlUYmlj?= =?utf-8?B?VzVpMU94bVJZNkpnZzd1VDJya21hR2NKQk1ESHRaTEt5R3NzY3A0a0dsM3Jm?= =?utf-8?B?dW05WFVLMUpaNzcxM080ZVJnRFc4ZlFtdXZjY1NrM2pKSFNTTDNiTkNtNk1w?= =?utf-8?B?RGdMbG8rUWRxRjN3SmltblNHVFhtWktvdGZEY2p3NWE1c3lhYmI4R2dJYXRV?= =?utf-8?B?OGxVSzArVWxZRk8vdVhHQ3dNZmtVbEZVQmdVUWorMWZ5VmdoaUszTUd2OUdU?= =?utf-8?B?Si91VDJJbFlpSlpzL1JmYVk0dHA3SVBEYm8xY2ZJeFp3bENLNFZzaFZySWpZ?= =?utf-8?B?ejZKRG8wbVNqOU9kNVhrczZVOG9VZWoySUZ2VU8zb2FwNTVybkZqNVlubVVx?= =?utf-8?B?Vlk2TnMwNk1LaEZZMHVVU2tKWm44MHJTc3pKVmZqejJSZ3Q4NmY0V0VFbnZT?= =?utf-8?B?cTU4QlR5cmlNOGFsUFJjemZSVXBDZWxPS3Y5aFdZSkVnUEZKc1dUM2lWVVp0?= =?utf-8?B?aExaYnZ0ZDlkSi9nRG8vK3AzaEJ2MmFieHNXSGdqM2Q3WEFXbDg3aXdXTXRw?= =?utf-8?B?RForbis5eXh2eUJLdWo2S0xxd2N3VU5Ob2x2Vi9kQlNUVThwaVdBcURWV24w?= =?utf-8?Q?kauSOH7hd5achZFZIc5taETnHEeBt/49?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB8281.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUpzRXJsWThDSWl5MTdVaTZUOW1UcTl5THFOdmdkeGpyS1N3V1RIQjZmMGts?= =?utf-8?B?QUFPcjQrRVVlZzlod2VmQ1NhUDVMSmtxbENidmRPanduZlF3amF4Zi9RREQ5?= =?utf-8?B?cFROVVdtTTZCVTJBS240TlNKLzYzSDZNTE81dVlkbE5mVndxZzlhSU5CVXZD?= =?utf-8?B?bE5weWhDWW9Da1pIUklFNjY1NXVaSlBpb2tHOE1CL3BpL0pjM2JKd3B5NWVp?= =?utf-8?B?U0hDL0Q0S3ZHeVZiMGNtUlRmTVZwb29DU2wrMEI2Zzd3RXhVQ1lWT3JxUE42?= =?utf-8?B?OWhseEc0MTVKbjMxd2QrSUNnRHZyNzRPWUY4U2Npcy90UVI4UU1ESWoxWUV2?= =?utf-8?B?UzBjOFhlbi9IelQwZVByenZKTlcvZzRTRzBkMHdEMlZaMnZoSUk2bEo0NnFm?= =?utf-8?B?bHlZdFJTV0NaeVloa29ZSlFkUlByY2lrQ1EvYzRvRWtkVWc2S0NIbSs2RVc3?= =?utf-8?B?dXVIRjk1M2RkTkU1Wjk5WkdQV1MzaytPQmJUN2NmaldGT0NkZE9iM1NkTzA4?= =?utf-8?B?UE9FL005bHl1NUVQUndsZEdxbnNTVWZuSWdQa2M4Q3ZlK1VEbmh3cEs1dlVv?= =?utf-8?B?RExySU1Wd01BNG5EWVNNOG5vTTdZVjlBVGN6NXl4NFRScWR4aHRSS3lPZWkz?= =?utf-8?B?OFFWZmszTGJUczNDV0RleHJRNnJoUlAxWXRXeHFYV0REbUExNElOYWtxNFRI?= =?utf-8?B?Q1lHYU5EenZOcHdtZHNCN1VUVjdaRnppc25tMDBKY1FaYlVFVlBQVGtIekZC?= =?utf-8?B?dlVQRWI2WFdVZ1pDc0lXTUViVmJRaVhmSTlkSUx1Umd1RmZvTWZXQk4wMGJG?= =?utf-8?B?ck9raW9xU202Q3VWb3dHTkV5bnJxT2ZzR2dEbmtxckFCdmFRVXNOMWRPK2R2?= =?utf-8?B?dDkvU0Y3RWlVSGViblBSL0s0aS96RkQrb3ZoWUthKzljbDdDK0tLVEVNcUd3?= =?utf-8?B?MXFpbFc1ak9ZbzcyOXBJekVkWldDaS9adkRReVFVaEpwaU5pZWxGMzNEL0xU?= =?utf-8?B?M0lPSWVEN0dqbW9XcnRDUlFCWXI5SHBxRlRva2lwaUgrMC91dXZDc21EZ2FZ?= =?utf-8?B?Y3lrUEk1WXVlSmVRLzlPd29VYkZMTDg0M3VPOTc5NzArR3k1eFl2R3dUQ1Zm?= =?utf-8?B?dVBrNG5sR1Z6Uk5JdTJJcFlBVjlWS05WSWlIU0ZTQml3VGNiL0pBb2VvRm5T?= =?utf-8?B?OGpQNmx2aXVnaTJ3aGtXRTVvWlR2bUZvWlZDNHNrSGJsT29RQ3laczNQTXJC?= =?utf-8?B?blVsejBQMTdmTDViWFIrQkw2Tm9vSENkTmRLZW1UQ3RCQVdZak91WW9tYWg2?= =?utf-8?B?Ulo0WGxEUElaOGFNcTEzYTVxeEtZeFdydTVMNmtQZ2VJaTlaSy9zZzBjQnhm?= =?utf-8?B?T085eGZrYjI0dlBhRStnQis5R3lIVXB1Ym5sWUhCTThLZ0NET1ZWZU40QXhX?= =?utf-8?B?NzJHMC9YMVNrVzhxcUZQc0FoblhGQ1VNS1J4SDdMV0pqQjVwQ3p1QTNZN1lI?= =?utf-8?B?cGM3emtSMjNKbTIwMFZXRG1CcjhLelpYOUxKQ0lSekE5M1hKVHNXSUtXd3pH?= =?utf-8?B?bkhweFdTOHZnKzc5ZWU3cW5kUGt3MnptY1Z4bXVBNHZqbzJiWGlMam56SDhX?= =?utf-8?B?QjlXVTVQbGZuRTNKNFVacE5mb2NqV2VVVURxVnFDc2ZxcFBqaVFWVk1vSDVz?= =?utf-8?B?N2ZxYUtmUkcxQlU2a0crNTM0N1dyMU1xV2xrSjQ1OVdKNVJ2MTl2dDFIRDdx?= =?utf-8?B?ZG5hVmJwZzQwYTJna0tGZVBJQ1orMkxiSkFXUThkMlJ0YjhENmsxZGNzRW05?= =?utf-8?B?VHlwaGYwZFQyV1N1L1NlY0FQTmZNTzVEZ2dmcGxneGtqajhqTlB4bTFINm85?= =?utf-8?B?TjBUZkx3bStsUHplOHpINWdsZHZZYzN0SmphdXNVdlFXUW83bURwa25Wdysv?= =?utf-8?B?ZFRyRjBBV1ZpRk5YT2FGYU1HQ1JFNUNlTmMyZTRTVk1ROERGbnpHZGtWbHhl?= =?utf-8?B?RFE5Ky9ncDBwdkdySTRiVjBjTmJySXNEQnoybTgzNFcwK2w4aWh2M1d6NzBj?= =?utf-8?B?OU9UN2pPMEFyWHg4QWNXUFBnNXhkeENEWHE3MkI3TWNQWEl3OFNhd3U2bklu?= =?utf-8?Q?P5ar2fdGgBc2Sf5ejb6BCiiTa?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3689f800-09b9-415d-87cf-08de39403c9a X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB8289.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2025 05:35:20.5690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z4Gs3Ofz/RVwJMcGavNI8C9GBokCpT4eavbnSeOsmj+Gdwr48VhlX8kggRd8bOHu7wpAdbSCXkUWTtvJ916LrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7811 X-OriginatorOrg: intel.com On 12/11/2025 1:16 PM, Oscar Salvador wrote: > On Mon, Dec 08, 2025 at 11:25:44PM +0800, Tianyou Li wrote: >> From: Yuan Liu >> >> Function set_zone_contiguous used __pageblock_pfn_to_page to >> check the whole pageblock is in the same zone. One assumption is >> the memory section must online, otherwise the __pageblock_pfn_to_page >> will return NULL, then the set_zone_contiguous will be false. >> When move_pfn_range_to_zone invoked set_zone_contiguous, since the >> memory section did not online, the return value will always be false. > Then, this means that zone->contiguous was always left false on new > memory-hotplug operations, if it was false before? > > I guess we did not notice this before because it is just an optimization > so we always took the long road. > > Nice catch. Thanks Oscar. Yuan Liu has done the test and compared the results thus found this issue. >> To fix this issue, we removed the set_zone_contiguous from the >> move_pfn_range_to_zone, and place it after memory section onlined. >> >> Function remove_pfn_range_from_zone did not have this issue because >> memory section remains online at the time set_zone_contiguous invoked. >> >> Reviewed-by: Tianyou Li >> Reviewed-by: Nanhai Zou >> Signed-off-by: Yuan Liu >> --- >> mm/memory_hotplug.c | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index d711f6e2c87f..f548d9180415 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -809,8 +809,7 @@ void move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn, >> { >> struct pglist_data *pgdat = zone->zone_pgdat; >> int nid = pgdat->node_id; >> - const enum zone_contig_state contiguous_state = >> - zone_contig_state_after_growing(zone, start_pfn, nr_pages); >> + >> clear_zone_contiguous(zone); >> >> if (zone_is_empty(zone)) >> @@ -840,8 +839,6 @@ void move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn, >> memmap_init_range(nr_pages, nid, zone_idx(zone), start_pfn, 0, >> MEMINIT_HOTPLUG, altmap, migratetype, >> isolate_pageblock); >> - >> - set_zone_contiguous(zone, contiguous_state); >> } >> >> struct auto_movable_stats { >> @@ -1150,6 +1147,7 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, >> { >> unsigned long end_pfn = pfn + nr_pages; >> int ret, i; >> + enum zone_contig_state contiguous_state = ZONE_CONTIG_NO; >> >> ret = kasan_add_zero_shadow(__va(PFN_PHYS(pfn)), PFN_PHYS(nr_pages)); >> if (ret) >> @@ -1164,6 +1162,10 @@ int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, >> if (mhp_off_inaccessible) >> page_init_poison(pfn_to_page(pfn), sizeof(struct page) * nr_pages); >> >> + if (IS_ALIGNED(end_pfn, PAGES_PER_SECTION)) >> + contiguous_state = zone_contig_state_after_growing(zone, pfn, >> + nr_pages); > Uhm, I think this deserves a little comment. > I guess that if we are not allocating memmap pages worth of a full > section, we keep it ZONE_CONTIG_NO. > > Discussed with Yuan. We will add the comments as you suggested in patch v6. Thanks. Regards, Tianyou >