From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759571AbcIXQmA (ORCPT <rfc822;w@1wt.eu>);
        Sat, 24 Sep 2016 12:42:00 -0400
Received: from mout.web.de ([212.227.17.12]:59418 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1759499AbcIXQl5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 24 Sep 2016 12:41:57 -0400
Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by
 pr_info() in joydump_connect()
To: Joe Perches <joe@perches.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <f486d64d-0759-9cd6-1e4e-df723acb6fea@users.sourceforge.net>
 <1474733610.23838.2.camel@perches.com>
Cc: linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <031de9c0-2e54-a6e4-3b61-73ce523bb769@users.sourceforge.net>
Date: Sat, 24 Sep 2016 18:41:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474733610.23838.2.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:FM+7kmEXOBjVuNB5i+OVq4r6EKdboyxAGlwsFgQMAnCEL52zGZ8
 52n44aflPa8wArBNi/9qMEPEr/bZcclG7WmwhG/+7j6HgU6D0qRE8YfPnRLJ/rNaWz6u2Kz
 hoPBhmTZjGKE+p7vTj4qPlfRhl08dL8rjjWngW67folQe+ATkC4N6saAGBP7/ohV7edgCj5
 dqNRZyA+y0aLQBRYrx4yw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:u4ywlLaRzMI=:2/IZOjstUjwCWR+/qJCrWX
 a8BNT4MoLTU6iTgdl/hjKLDRAZpToO1bOvb/YQH3l8TXz8LJXI2+OWKzjG1uPuS2lxEz9O67h
 8n+lb5GFAPgUzWLfxc1487mTfydGo0gJKmEmM/v4TfZK5JS3jbQywg8TTjssbdkSP+3D1LMSr
 3YtJmOOm5atvIRkXDZWhPWrVQ//TQDVLjB4gF/p7ifuVs1UQwE2z58vb1zlGQ4ooXpvxVUzMd
 FSE6fZ5dL31GOrVbb5s6vSiscKMDiVAKWhCZKO7FlGNX67U5ViukJcA87DTQ7d8xi6Vl9ylLN
 DUUEDpjII5zGZ357OpNqrVmCXiHMElk3QFXsOyUEMqXzwLKywHGkRIBjvKyYGL0473+CTRv2r
 FA5+qJf8TYE+jeMWzOnpLwZ+AsFdK8ihAGgnP5xAv1xsvIsJE4O20FMrFfLP3OVwERubMSIaG
 1BLLye2tot7q50HYg1RJDxhFL88Oa1vy+faoJYPCEPjs7ad1CRXgNgwyXH+c4Q+vkgbjafa7L
 0RfRLZvLqwJS+5Qrf6wkvuFOX7b8F8B/wH4NRyi99GiWeG+QPcCx4tZerr6VPJHbITl4qRGig
 t5pb3izoPLtXUUhD4shulX7pcFXH6aTGdCVi2x/lxS3WN2k3aenjFds9UA1JjK6vRdHLoiihT
 UnSUvtK6idSIgO204uVoOOc1pmmo3tn6G3VdlYFU4cJ9pEzuxAqKyFJ/lxBsoeYjaVuuUbHJ5
 vMd3NOqm6FW4mlyM6Ig2jekmghvWBexcWEU5eNPFYkJpC1+NjOfj/9ueD974HDegBpvkFO+He
 +A3jop4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
>>>  	unsigned long flags;
>>>  	unsigned char u;
>>  
>>> -	printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
>>> -	printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
>>> -	printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
>>> +	pr_info(",------------------ START ----------------.\n"
>>> +		"| Dumping: %30s |\n"
>>> +		"| Speed: %28d kHz |\n",
>>> +		gameport->phys,
>>> +		gameport->speed);
> 
> Not the same output.

Do you insist that each line from a multi-line text that is passed by such a single logging call
contains the same module prefix?

Regards,
Markus