mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-clk@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v3 1/6] dt-bindings: net: dwmac: Convert socfpga dwmac to DT schema
Date: Sat, 7 Dec 2024 21:22:34 +0100	[thread overview]
Message-ID: <031e9299-4722-42ef-94e9-ec4985a0e73d@lunn.ch> (raw)
In-Reply-To: <20241205-v6-12-topic-socfpga-agilex5-v3-1-2a8cdf73f50a@pengutronix.de>

> +  phy-mode:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      The phy mode the ethernet operates in.

I think you should be getting this via ethernet-controller.yaml. And
it is not a phandle.

> +
> +  altr,sgmii-to-sgmii-converter:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the TSE SGMII converter.
> +
> +      This device node has additional phandle dependency, the sgmii converter
> +        - compatible that should be altr,gmii-to-sgmii-2.0
> +        - reg-names that should be "eth_tse_control_port"

Is this a PCS?


    Andrew

---
pw-bot: cr

  parent reply	other threads:[~2024-12-07 20:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05  9:06 [PATCH v3 0/6] ARM64: dts: intel: agilex5: add nodes and new board Steffen Trumtrar
2024-12-05  9:06 ` [PATCH v3 1/6] dt-bindings: net: dwmac: Convert socfpga dwmac to DT schema Steffen Trumtrar
2024-12-05 10:48   ` Rob Herring (Arm)
2024-12-07 20:22   ` Andrew Lunn [this message]
2024-12-05  9:06 ` [PATCH v3 2/6] dt-bindings: net: dwmac: add compatible for Agilex5 Steffen Trumtrar
2024-12-05  9:06 ` [PATCH v3 3/6] arm64: dts: agilex5: add gmac nodes Steffen Trumtrar
2024-12-05  9:06 ` [PATCH v3 4/6] arm64: dts: agilex5: add gpio0 Steffen Trumtrar
2024-12-05  9:06 ` [PATCH v3 5/6] dt-bindings: intel: add agilex5-based Arrow AXE5-Eagle Steffen Trumtrar
2024-12-05  9:06 ` [PATCH v3 6/6] arm64: dts: agilex5: initial support for " Steffen Trumtrar
2024-12-07 20:26   ` Andrew Lunn
2024-12-06 22:13 ` [PATCH v3 0/6] ARM64: dts: intel: agilex5: add nodes and new board Stephen Boyd
2024-12-09  9:21   ` Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=031e9299-4722-42ef-94e9-ec4985a0e73d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®