mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ata: ahci: Skip 200 ms debounce delay for Marvell 88SE9235
Date: Thu, 3 Feb 2022 08:49:42 +0900	[thread overview]
Message-ID: <031eceaf-402f-7bca-10c4-8959e62e7fe3@opensource.wdc.com> (raw)
In-Reply-To: <4c3df325-dc9f-5eed-5585-7d2e5203b65f@opensource.wdc.com>

On 2/3/22 08:05, Damien Le Moal wrote:
>>> ata: ahci: Add support for Marvell 88SE9235 adapter
>>>
>>> Since it is exactly what this patch is doing by adding a PCI ID.
>>
>> Thank you for applying the patch. I saw the summary/title change also 
>> with the other patch. I am sorry, but I totally disagree. Reading that 
>> summary/title in `git log --oneline`, it’s not clear at all, what the 
>> patch does, and the full description or diff has to be read. “Add 
>> support” for me means, that it was unsupported before, which is not true 
>> at all as the defaults were used.
> 
> Right... I did not consider the final entry in the ahci_pci_tbl table
> which matches against the device against the PCI AHCI storage class.
> So right you are. I will restore your original commit title/message.
> 
> Thanks for checking.

Fixed now !


-- 
Damien Le Moal
Western Digital Research

      reply	other threads:[~2022-02-02 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  7:12 Paul Menzel
2022-02-01  8:27 ` Damien Le Moal
2022-02-02  8:14 ` Damien Le Moal
2022-02-02 14:29   ` Paul Menzel
2022-02-02 23:05     ` Damien Le Moal
2022-02-02 23:49       ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=031eceaf-402f-7bca-10c4-8959e62e7fe3@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®