From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbdB0Ul0 (ORCPT ); Mon, 27 Feb 2017 15:41:26 -0500 Received: from mga04.intel.com ([192.55.52.120]:60055 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbdB0UlY (ORCPT ); Mon, 27 Feb 2017 15:41:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,215,1484035200"; d="scan'208";a="230321197" Subject: Re: [PATCH] mm,fs,dax: mark dax_iomap_pmd_fault as const To: Arnd Bergmann , Alexander Viro , Matthew Wilcox , Ross Zwisler References: <20170227203349.3318733-1-arnd@arndb.de> Cc: Jan Kara , Andrew Morton , Dave Chinner , Vishal Verma , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org From: Dave Jiang Message-ID: <03239288-0aff-98b7-e176-4954ecc6359c@intel.com> Date: Mon, 27 Feb 2017 13:38:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170227203349.3318733-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/27/2017 01:33 PM, Arnd Bergmann wrote: > The two alternative implementations of dax_iomap_fault have different > prototypes, and one of them is obviously wrong as seen from this build > warning: > > fs/dax.c: In function 'dax_iomap_fault': > fs/dax.c:1462:35: error: passing argument 2 of 'dax_iomap_pmd_fault' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] > > This marks the argument 'const' as in all the related functions. > > Fixes: a2d581675d48 ("mm,fs,dax: change ->pmd_fault to ->huge_fault") > Signed-off-by: Arnd Bergmann Thanks Arnd. I posted the same fix this morning. :) http://marc.info/?l=linux-mm&m=148821429608976&w=2 > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index d5712f42a2e6..85479428518f 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -1436,7 +1436,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > return result; > } > #else > -static int dax_iomap_pmd_fault(struct vm_fault *vmf, struct iomap_ops *ops) > +static int dax_iomap_pmd_fault(struct vm_fault *vmf, const struct iomap_ops *ops) > { > return VM_FAULT_FALLBACK; > } >